Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-43858: Add logging.getLevelNamesMapping()#26459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@akulakov
Copy link
Contributor

@akulakovakulakov commentedMay 31, 2021•
edited by bedevere-bot
Loading

Added a function that returns a copy of a dict of logging levels.

https://bugs.python.org/issue43858

Copy link
Member

@ericvsmithericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This needs tests. In particular it should add tests that a copy is returned.

vsajip reacted with thumbs up emoji
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@akulakov
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ericvsmith: please review the changes made to this pull request.

Copy link
Member

@ericvsmithericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is looking good to me.@vsajip : I'll let you have the final word.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@@ -0,0 +1 @@
Added a function that returns a copy of a dict of logging levels: func::`logging.getLevelNamesMapping()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Now that I look at this: isn't the correct syntax:

:func:`logging.getLevelNamesMapping`

?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You are right, well spotted!

@akulakov
Copy link
ContributorAuthor

@vsajip@ericvsmith Pushed an update per comments, please take a look!

Copy link
Member

@ericvsmithericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

With the one small item I mentioned, this looks good to me.

@@ -0,0 +1 @@
Added a function that returns a copy of a dict of logging levels::func:`logging.getLevelNamesMapping()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My understanding is that:func: adds the parens, so you should leave them off in this message. I've looked at other files, and they don't have the parens.

akulakov reacted with thumbs up emoji
@akulakov
Copy link
ContributorAuthor

@ericvsmith I fixed the parens, please take a look..

Copy link
Member

@vsajipvsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Accidental double-definition in test?

self.assertEqual(rc,1)

deftest_get_level_names_mapping(self):
deftest_get_level_names_mapping(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think you meant this double level of indentation! That causes the test to do nothing effective 😞

akulakov reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Whoops, somehow doubling made it hard to spot for me..

@akulakov
Copy link
ContributorAuthor

@vsajip Fixed the doubled test..

Copy link
Member

@ericvsmithericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This all looks good to me. Thanks,@akulakov !

@akulakovakulakov changed the titlebpo-43858: Add logging.getLevelNamesDict()bpo-43858: Add logging.getLevelNamesMapping()Jun 2, 2021
@akulakov
Copy link
ContributorAuthor

@ericvsmith and@vsajip much thanks for the help with the PR!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ericvsmithericvsmithericvsmith requested changes

@vsajipvsajipvsajip approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akulakov@bedevere-bot@vsajip@ericvsmith@the-knights-who-say-ni@miss-islington
[8]ページ先頭
©2009-2025 Movatter.jp