Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-43216: Remove @asyncio.coroutine#26369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 7 commits intopython:mainfromillia-v:bpo-43216
Jul 1, 2021
Merged

Conversation

@illia-v
Copy link
Contributor

@illia-villia-v commentedMay 25, 2021
edited
Loading

@asyncio.coroutine was scheduled for removal in Python 3.10 originally.

https://bugs.python.org/issue43216

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@illia-villia-v requested a review fromvstinnerMay 26, 2021 16:59
@illia-villia-v requested a review fromvstinnerMay 26, 2021 20:27
@illia-villia-v requested a review fromvstinnerMay 26, 2021 20:49
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. But I would prefer that@1st1 or@asvetlov merged it.

I only quickly looked at test changes. I'm fine with removing legacy @asyncio.coroutine, async def is now standard and preferred.

illia-v and graingert reacted with hooray emoji
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelJul 1, 2021
@graingert
Copy link
Contributor

This isn't stale

@graingert
Copy link
Contributor

@1st1@asvetlov

@vstinnervstinner reopened thisJul 1, 2021
@vstinner
Copy link
Member

vstinner commentedJul 1, 2021
edited
Loading

multiprocessing tests hang on Address sanitizer. I cannot merge the PR because of it :-(

cc@pablogsal

@pablogsal
Copy link
Member

pablogsal commentedJul 1, 2021
edited
Loading

multiprocessing tests hang on Address sanitizer. I cannot merge the PR because of it :-(

That's weird. Maybe run them again? We can look into increasing timeout for that run or excluding those

@corona10corona10 requested a review fromaerosJuly 1, 2021 02:20
@vstinnervstinner merged commita1092f6 intopython:mainJul 1, 2021
@vstinner
Copy link
Member

Merged, thanks.

I decided to no longer wait for@1st1 or@asvetlov since they seem to be busy. The change looks reasonable.

If this change breaks too many asyncio project, we can consider to revert it, help projects to migrate, and reschedule the removal once enough projects migrated. I hope that in 2021, most projects are now written with "async def" and "await". The@coroutine syntax is a legacy of Python 3.4-3.5 era. I know that one of reasons why Instagram migrated from Python 2.7 to 3.6 is to getasync def syntax!

@graingert
Copy link
Contributor

graingert commentedJul 1, 2021
edited
Loading

@vstinner did this miss the deadline for py3.10 backport?

@illia-v
Copy link
ContributorAuthor

illia-v commentedJul 1, 2021
edited
Loading

Thanks@vstinner &@graingert!


@vstinner did this miss the deadline for py3.10 backport?

This removal was discussed shortly before the 3.10 feature freeze. Victorsuggested to wait for Python 3.11 to remove the decorator.

graingert reacted with thumbs up emoji

@illia-villia-v deleted the bpo-43216 branchJuly 1, 2021 13:43
@vstinner
Copy link
Member

This removal was discussed shortly before the 3.10 feature freeze. Victor suggested to wait for Python 3.11 to remove the decorator.

Exactly ;-)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@graingertgraingertgraingert approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@aerosaerosAwaiting requested review from aeros

Assignees

No one assigned

Labels

staleStale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@illia-v@graingert@vstinner@pablogsal@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp