Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-42627: Fix wrong parsing of Windows registry proxy settings#26307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 24 commits intopython:mainfromCrazyBoyFeng:fix-issue-42627
May 11, 2022
Merged

bpo-42627: Fix wrong parsing of Windows registry proxy settings#26307

zooba merged 24 commits intopython:mainfromCrazyBoyFeng:fix-issue-42627
May 11, 2022

Conversation

@CrazyBoyFeng
Copy link
Contributor

@CrazyBoyFengCrazyBoyFeng commentedMay 22, 2021•
edited
Loading

In Windows registry proxy settings,https=host:456 does not mean that the proxy server communicates with the client through the HTTPS protocol, but it means that the proxy server proxies the client's traffic to the HTTPS website. The proxy server itself communicates with the client through the HTTP protocol by default.

fixpypa/pip#9568fixpypa/pip#9614fixurllib3/urllib3#2164fixpsf/requests#5740

https://bugs.python.org/issue42627

kotori2, keuin, jiasli, gfxonline, FantasqueX, Zxilly, and zhoudachan reacted with thumbs up emoji
@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@CrazyBoyFeng

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@CrazyBoyFengCrazyBoyFeng marked this pull request as ready for reviewMay 24, 2021 13:48
@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@testinguser

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

CrazyBoyFengand others added3 commitsMay 28, 2021 14:17
To compat with customary formats from software such as `requests[socks]`
@zooba
Copy link
Member

@CrazyBoyFeng Looks like you're going to hit a known error in CI right now. Merging the latest from master should fix it.

@CrazyBoyFeng
Copy link
ContributorAuthor

I've synced the branch to the latest, hope this works.

gfxonline reacted with heart emoji

@miss-islington
Copy link
Contributor

Thanks@CrazyBoyFeng for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@CrazyBoyFeng for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@CrazyBoyFeng for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 11, 2022
…ythonGH-26307)(cherry picked from commitb69297e)Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@bedevere-bot
Copy link

GH-92684 is a backport of this pull request to the3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 11, 2022
…ythonGH-26307)(cherry picked from commitb69297e)Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelMay 11, 2022
@bedevere-bot
Copy link

GH-92685 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 11, 2022
…ythonGH-26307)(cherry picked from commitb69297e)Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelMay 11, 2022
@bedevere-bot
Copy link

GH-92686 is a backport of this pull request to the3.11 branch.

miss-islington added a commit that referenced this pull requestMay 11, 2022
…H-26307)(cherry picked from commitb69297e)Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
miss-islington added a commit that referenced this pull requestMay 11, 2022
…H-26307)(cherry picked from commitb69297e)Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
zooba pushed a commit that referenced this pull requestMay 12, 2022
…H-26307)(cherry picked from commitb69297e)Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull requestJun 2, 2022
…ythonGH-26307)(cherry picked from commitb69297e)Co-authored-by: 狂男风 <CrazyBoyFeng@Live.com>
@cyfex
Copy link

In Ubuntu 22.04, pip 23.1.2, python 3.10, this issue is still an issue. It seems not to be able to handle socks5 proxy properly.

@zooba
Copy link
Member

Please file a new issue. It's no good commenting on an already completed PR that had nothing to do with your concern.

@pythonpython locked asresolvedand limited conversation to collaboratorsMay 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@zoobazoobazooba left review comments

+1 more reviewer

@keuinkeuinkeuin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

9 participants

@CrazyBoyFeng@the-knights-who-say-ni@zooba@gfxonline@sethmlarson@miss-islington@bedevere-bot@cyfex@keuin
[8]ページ先頭
©2009-2025 Movatter.jp