Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
bpo-36203: Check callback is callable in PyWeakref_NewRef#26273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
The documentation says that `PyWeakref_NewRef` should raise a`TypeError` if the callback is not callable, None, or NULL, but the codedoes not reflect the documentation. This PR fixes that.
Tests failing seem entirely unrelated |
This PR is stale because it has been open for 30 days with no activity. |
bump? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Runs ok on my Ubuntu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This has merge conflicts now.
bedevere-bot commentedDec 6, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
ghost commentedDec 17, 2022
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
| @@ -0,0 +1 @@ | |||
| Amend PyWeakref_New to raise a TypeError if the callback given is not NULL, None, or a callable object. The documentation previously falsely claimed this check occurred. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Amend PyWeakref_New to raiseaTypeError if the callback given is not NULL, None, or a callable object. The documentation previously falsely claimed this check occurred. | |
| Amend:c:func:`PyWeakref_New` to raise:exc:`TypeError` if the*callback* given is not NULL, None, or a callable object. The documentation previously falsely claimed this check occurred. | |
python-cla-botbot commentedApr 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The following commit authors need to sign the Contributor License Agreement: |
Uh oh!
There was an error while loading.Please reload this page.
The documentation says that
PyWeakref_NewRefshould raise aTypeErrorif the callback is not callable, None, or NULL, but the codedoes not reflect the documentation. This PR fixes that.
This should probably be backported to whatever version of Python
changed that documentation.
https://bugs.python.org/issue36203