Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
bpo-38291: Remove mention of typing.io and typing.re again#26113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
They were originally removed inpythonGH-10173 per bpo-35089, but thenreadded inpythonGH-21574. Cf. bpo-38291 for decision to remove.
Wouldn't it be better to say these namespaces are deprecated? The feature was promised in PEP 484 and previously mentioned in the typing docs, so we can't just hide it completely. Here's a possible proposal:
|
Sounds good. I will modify this text tomorrow to a deprecation notice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe the docs should actually list these as deprecated? (That would presumably be a "deprecated" note for the entire typing module.)
+1 to this proposal and for removing them in 3.13 (3.12 might be too early since thats only 1 version of warnings). |
I have now added a deprecation notice instead of removing mentioning them completely. I marked them as deprecated as of 3.8 (since that was the version where they were removed first from the docs according to the NEWS entry). I also used a removal version of 3.12 for now. Since they were never supported, I'd be surprised if removing them has much of an impact. Also, the fix is very easy and works with all typing versions. |
Looks like you may not have pushed your changes. |
Oops. Done now. |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I feel this needs a NEWS entry. If you add one I will merge it. I'll also mark it for backporting.
@gvanrossum Done. |
Thanks@srittau for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
…26113)They were originally removed inpythonGH-10173 per bpo-35089, but thenreadded inpythonGH-21574. Cf. bpo-38291 for decision to remove.(cherry picked from commit8a76683)Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
bedevere-bot commentedJun 14, 2021
GH-26720 is a backport of this pull request to the3.10 branch. |
…26113)They were originally removed inpythonGH-10173 per bpo-35089, but thenreadded inpythonGH-21574. Cf. bpo-38291 for decision to remove.(cherry picked from commit8a76683)Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
bedevere-bot commentedJun 14, 2021
GH-26721 is a backport of this pull request to the3.9 branch. |
…26113)They were originally removed inpythonGH-10173 per bpo-35089, but thenreadded inpythonGH-21574. Cf. bpo-38291 for decision to remove.
Uh oh!
There was an error while loading.Please reload this page.
They were originally removed inGH-10173 perbpo-35089, but then
readded inGH-21574. Cf.bpo-38291 for decision to remove. This PR
only partly addresses this bug, as the modules should be deprecated as
well (as they were never properly supported.)
https://bugs.python.org/issue38291