Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-44116: Add GC support to _csv heap types#26074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 4 commits intopython:mainfromerlend-aasland:gc-csv
May 12, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMay 12, 2021•
edited
Loading

  • Implement full GC protocol support for _csv heap types
  • Use tp_clear iso. tp_finalize to clear type contexts

Petr's reproducer now outputs the following:

$ ./python.exe bug.py73166731687316873168731687316873166731687316873168

However, the _csv test suite now leaks (EDIT: updated output afterb8772d6)
UPDATE: No leaks after19e2952

https://bugs.python.org/issue44116

@erlend-aasland
Copy link
ContributorAuthor

(I'm applyingskip news to this,@pablogsal (@corona10), as it is similar toGH-26072.)

corona10 reacted with thumbs up emoji

Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Some minor nits below:

@erlend-aaslanderlend-aasland marked this pull request as ready for reviewMay 12, 2021 16:55
@Fidget-Spinner
Copy link
Member

Doh I should've refreshed before I submitted the review. Didn't see your latest commits :(. Sorry.

@erlend-aasland
Copy link
ContributorAuthor

Doh I should've refreshed before I submitted the review. Didn't see your latest commits :(. Sorry.

No problem, Ken :) I believe all your comments were addressed in19e2952.

Fidget-Spinner reacted with thumbs up emoji

@erlend-aaslanderlend-aasland changed the title[WIP] bpo-44116: Add GC support to _csv heap typesbpo-44116: Add GC support to _csv heap typesMay 12, 2021
@pablogsal
Copy link
Member

One thing that I don't understand is why the CSV tests when executed under the refleak checker don't show any problems

erlend-aasland reacted with eyes emoji

@pablogsal
Copy link
Member

Does this need backport to 3.9?

@pablogsalpablogsal merged commite5ba1fe intopython:mainMay 12, 2021
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26081 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelMay 12, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2021
(cherry picked from commite5ba1fe)Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aaslanderlend-aasland deleted the gc-csv branchMay 12, 2021 18:21
@erlend-aasland
Copy link
ContributorAuthor

Does this need backport to 3.9?

No. This was added in December inGH-23224

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedMay 12, 2021•
edited
Loading

Thanks for reviewing, Pablo and Ken!

pablogsal pushed a commit that referenced this pull requestMay 12, 2021
@encukou
Copy link
Member

Thank you for pushing this through!

erlend-aasland reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

@encukouencukouAwaiting requested review from encukou

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erlend-aasland@Fidget-Spinner@pablogsal@miss-islington@bedevere-bot@encukou@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp