Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-38908: Fix issue when non runtime_protocol does not raise TypeError#26067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gvanrossum merged 4 commits intopython:mainfromuriyyo:fix-issue-38908
May 12, 2021

Conversation

@uriyyo
Copy link
Member

@uriyyouriyyo commentedMay 12, 2021•
edited by bedevere-bot
Loading

@Fidget-SpinnerFidget-Spinner self-requested a reviewMay 12, 2021 14:11
@uriyyouriyyo changed the titlebpo-38908: Fix issue when non runtime_protocol does not raise TypeErrorbpo-38908: Add tests to cover case when non runtime_protocol does not raise TypeErrorMay 12, 2021
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yurii, thanks for sending a PR to make sure there are no regressions for this long-standing issue!

@uriyyouriyyo changed the titlebpo-38908: Add tests to cover case when non runtime_protocol does not raise TypeErrorbpo-38908: Fix issue when non runtime_protocol does not raise TypeErrorMay 12, 2021
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@uriyyo
Copy link
MemberAuthor

@Fidget-Spinner It is not regression, I made a mistake when said that this issue was not present at 3.11 version. This issue still present and this PR will fix it.

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner It is not regression, I made a mistake when said that this issue was not present at 3.11 version. This issue still present and this PR will fix it.

Oh interesting!class P(Protocol): ... raises as expected, but

classP(Protocol):x :int

doesn't!

Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Once again, thank you for fixing this!

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Does this need backporting?

@bedevere-bot
Copy link

@gvanrossum: Please replace# withGH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks@uriyyo for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2021
…ror (pythonGH-26067)(cherry picked from commitc40486a)Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
@bedevere-bot
Copy link

GH-26073 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelMay 12, 2021
@miss-islington
Copy link
Contributor

Sorry,@uriyyo and@gvanrossum, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker c40486a32d7e37b01ead94e701d69847f5b60e30 3.9

@Fidget-Spinner
Copy link
Member

Sorry,@uriyyo and@gvanrossum, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker c40486a32d7e37b01ead94e701d69847f5b60e30 3.9

I'm on it. It's clashing because the_allow_reckless_class_checks was previously_allow_reckless_class_cheks and the typo fix wasn't backported.

uriyyo reacted with thumbs up emoji

@bedevere-bot
Copy link

GH-26075 is a backport of this pull request to the3.9 branch.

miss-islington added a commit that referenced this pull requestMay 12, 2021
…ror (GH-26067)(cherry picked from commitc40486a)Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
miss-islington pushed a commit that referenced this pull requestMay 12, 2021
…ypeError (GH-26067) (GH-26075)(cherry picked from commit c40486a)Co-authored-by: Yurii Karabas 1998uriyyo@gmail.comAutomerge-Triggered-By: GH:gvanrossum
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull requestMay 12, 2021
miss-islington pushed a commit that referenced this pull requestMay 12, 2021
…es not raise TypeError (GH-26067)" (GH-26077)Reverts#26075Automerge-Triggered-By: GH:gvanrossum
srittau pushed a commit to python/typing_extensions that referenced this pull requestApr 12, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

@ilevkivskyiilevkivskyiAwaiting requested review from ilevkivskyi

Assignees

@gvanrossumgvanrossum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@uriyyo@Fidget-Spinner@bedevere-bot@miss-islington@gvanrossum@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp