Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
bpo-44113: Deprecate old functions to config Python init#26060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Don't we have to change the signature of API like this? from Include/sysmodule.h Py_DEPRECATED(3.11)PyAPI_FUNC(void)PySys_AddWarnOption(constwchar_t*); |
@corona10: Oh right, I added Py_DEPRECATED(). I rebased my PR and also deprecated PySys_HasWarnOptions(). |
Deprecate the following functions to configure the Pythoninitialization:* PySys_AddWarnOption()* PySys_AddWarnOptionUnicode()* PySys_AddXOption()* PySys_HasWarnOptions()* Py_SetPath()* Py_SetProgramName()* Py_SetPythonHome()* Py_SetStandardStreamEncoding()* _Py_SetProgramFullPath()Use the new PyConfig API of the Python Initialization Configurationinstead (PEP 587).
I also deprecated the undocumented _Py_SetProgramFullPath() function. |
@corona10: Would you mind to review the updated PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
Uh oh!
There was an error while loading.Please reload this page.
Deprecate the following functions to configure the Python
initialization:
Use the new PyConfig API of the Python Initialization Configuration
instead (PEP 587).
https://bugs.python.org/issue44113