Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-44092: Don't reset statements/cursors before rollback#26026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 21 commits intopython:mainfromerlend-aasland:sqlite-rollback
Jan 3, 2022

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMay 10, 2021•
edited
Loading

In SQLite versions pre 3.7.11, pending statements would block a
rollback. We now require SQLite 3.7.15, so this workaround can go.

https://bugs.python.org/issue44092

In SQLite versions pre 3.7.11, pending statements would block arollback.  This is no longer the case, so remove the workaround.
@erlend-aasland
Copy link
ContributorAuthor

Tests taken from issue 33376

@erlend-aaslanderlend-aasland changed the titlebpo-44092: Don't reset statements/cursors before rollback[WIP] bpo-44092: Don't reset statements/cursors before rollbackMay 10, 2021
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedMay 11, 2021•
edited
Loading

@corona10 This change means thatInterfaceError is no longer raised for fetch across rollbacks. This is clearly a change in behaviour, but I can't see how it would break existing apps other than peoples fault handlers not being called :) I guess this also needs a What's New item. I'll expand this in the bpo instead of here.

UPDATE: seemsg393944

@erlend-aaslanderlend-aasland changed the title[WIP] bpo-44092: Don't reset statements/cursors before rollbackbpo-44092: Don't reset statements/cursors before rollbackMay 19, 2021
@erlend-aaslanderlend-aasland marked this pull request as ready for reviewMay 19, 2021 10:56
@erlend-aaslanderlend-aasland added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelSep 8, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commitf7065b1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelSep 8, 2021
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedNov 10, 2021•
edited
Loading

@serhiy-storchaka, I'm not sure how to proceed in order to land this. I'm pretty sure this is correct; it works across all supported SQLite versions. I've tried to ping Berker about this, but I haven't gotten any response. Proposal: We merge this tomain now; it is still early in 3.11 development, so we have plenty of time to get feedback from the community. For example, the Django people have an extensive sqlite3 test suite, and the've been very quick to report regressions or inaccuracies earlier. If, for some reason, we conclude this is the wrong fix, it will be easy to revert it with good margin before the feature freeze/beta.

See the bpo issue for my notes about this fix.

@erlend-aasland
Copy link
ContributorAuthor

@animalize: would you mind reviewing this?

@ghost
Copy link

I will try, I'm not a deep user of SQL, but if you can't find a reviewer I'm glad to try, hope I can review this in 2~4 weeks.

erlend-aasland reacted with heart emoji

@erlend-aasland
Copy link
ContributorAuthor

I will try, I'm not a deep user of SQL, but if you can't find a reviewer I'm glad to try, hope I can review this in 2~4 weeks.

Great, thanks. You'll find my reasoning in the bpo.

@erlend-aasland
Copy link
ContributorAuthor

@ghaering: Would you mind reviewing this? (A 👎🏻 or 👍🏻 reaction would be 👌🏻). Totally understand if you won't.

@ghost
Copy link

It seemsreset variable can be removed frompysqlite_Cursor struct.
I'm not a core developer, maybe no one listens to my opinion, but I will help you to find problems.

erlend-aasland reacted with heart emoji

@erlend-aasland
Copy link
ContributorAuthor

Thanks for helping out,@animalize!

@erlend-aaslanderlend-aasland removed the request for review fromserhiy-storchakaJanuary 2, 2022 09:24
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedJan 2, 2022•
edited
Loading

@pablogsal, it would have been nice to get this into the upcoming alpha :)

@ghost
Copy link

It seems this PR can be committed. Then to do subsequent improvement.

@pablogsalpablogsal merged commit9d6a239 intopython:mainJan 3, 2022
@erlend-aaslanderlend-aasland deleted the sqlite-rollback branchJanuary 3, 2022 19:31
@erlend-aasland
Copy link
ContributorAuthor

Thank you, Pablo! 🙏🏻

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@pablogsal@the-knights-who-say-ni
[8]ページ先頭
©2009-2026 Movatter.jp