document the optionalcallback parameter ofweakref.WeakMethod;
normalise the use of ‘proxy’, replacing the mix of ‘proxy’ (8 occurrences) and ‘proxy object’ (3 occurrences);
normalise the use of ‘weak reference’, replacing the mix of ‘weak reference’ (37 occurrences), ‘weak reference object’ (7 occurrences), ‘reference’ (7 occurrences), ‘reference object’ (6 occurrences), ‘weakref’ (3 occurrences), and ‘weakref object’ (1 occurrence).

https://bugs.python.org/issue47220

Update weakref.rst

4d950a8

the-knights-who-say-ni added the CLA signed label

Apr 20, 2021

bedevere-bot added docs

Documentation in the Doc dir

awaiting review labels

Apr 20, 2021

geryogam added2 commits

April 22, 2021 12:15

Update weakref.rst

c2d8a6b

Add the undocumented optional callback parameter to WeakMethod

0897c44

geryogam marked this pull request as ready for review

April 23, 2021 22:03

Copy link

github-actionsbot commentedJun 3, 2021

This PR is stale because it has been open for 30 days with no activity.

github-actionsbot added the staleStale PR or inactive for long period of time. label

Jun 3, 2021

JelleZijlstra self-requested a review

April 2, 2022 23:20

Merge branch 'main' into patch-25

37a75fe

JelleZijlstra added skip issue skip news needs backport to 3.9

only security fixes

needs backport to 3.10only security fixes and removed skip issue skip news labels

Apr 3, 2022

Copy link

Member

JelleZijlstra commentedApr 3, 2022

Sorry this had to wait for so long!

Documenting thecallback parameter toWeakMethod requires an issue and a NEWS entry in my view. Also, the documentation should say what the parameter does.
Some of the wording changes feel gratuitous (e.g. "proxy objects" vs. "proxies"). I don't know if the original authors had reasons for using one form or the other, so I'd be hesitant to make changes without a strong reason.

JelleZijlstra removed their request for review

April 3, 2022 03:30

merwok reviewed

Apr 3, 2022

View reviewed changes

Doc/library/weakref.rst OutdatedShow resolvedHide resolved

geryogam added2 commits

April 4, 2022 22:51

Document the callback parameter to WeakMethod

819a583

Create 2022-04-04-22-54-11.bpo-47167.nCNHsB.rst

7e437b5

geryogam changed the title~~Update weakref.rst~~bpo-47220: Document the optional callback parameter of weakref.WeakMethod

Apr 4, 2022

geryogam changed the title~~bpo-47220: Document the optional callback parameter of weakref.WeakMethod~~Document the optional callback parameter of weakref.WeakMethod

Apr 4, 2022

geryogam changed the title~~Document the optional callback parameter of weakref.WeakMethod~~bpo-47220: Document the optional callback parameter of weakref.WeakMethod

Apr 4, 2022

geryogam added3 commits

April 4, 2022 23:07

Rename 2022-04-04-22-54-11.bpo-47167.nCNHsB.rst to 2022-04-04-22-54-1…

52a0e64

…1.bpo-47220.L9jYu4.rst

Update 2022-04-04-22-54-11.bpo-47220.L9jYu4.rst

afcabae

Update 2022-04-04-22-54-11.bpo-47220.L9jYu4.rst

da83bd6

Copy link

ContributorAuthor

geryogam commentedApr 4, 2022•
edited
Loading

@JelleZijlstra @merwok Thanks for the review.

Documenting thecallback parameter toWeakMethod requires an issue and a NEWS entry in my view. Also, the documentation should say what the parameter does.

Done.

Some of the wording changes feel gratuitous (e.g. "proxy objects" vs. "proxies"). I don't know if the original authors had reasons for using one form or the other, so I'd be hesitant to make changes without a strong reason.

I normalised the use of ‘proxy’ because a mix of ‘proxy’ (8 occurrences) and ‘proxy object’ (3 occurrences) was used.

Update 2022-04-04-22-54-11.bpo-47220.L9jYu4.rst

b8a0169

bedevere-bot removed the awaiting review label

Nov 27, 2022

Copy link

bedevere-bot commentedNov 27, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot added the awaiting changes label

Nov 27, 2022

geryogam added2 commits

November 28, 2022 17:07

Revert "Update weakref.rst"

f19e8a1

This reverts commitc2d8a6b.

Revert "Normalise and disambiguate"

b60d38b

This reverts commit7a78eeb.

Copy link

ContributorAuthor

geryogam commentedNov 28, 2022

Please remove all unrelated changes.

Reverted. I have made the requested changes; please review again.

bedevere-bot added awaiting change review and removed awaiting changes labels

Nov 28, 2022

Copy link

bedevere-bot commentedNov 28, 2022

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

bedevere-bot requested a review fromerlend-aasland

November 28, 2022 16:15

erlend-aasland requested a review fromrhettinger

November 28, 2022 21:30

rhettinger approved these changes

Nov 30, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels

Nov 30, 2022

rhettinger removed the needs backport to 3.10only security fixes label

Nov 30, 2022

rhettinger merged commit9628136 intopython:main

Nov 30, 2022

Copy link

Contributor

miss-islington commentedNov 30, 2022

Thanks @maggyero for the PR, and@rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Nov 30, 2022

Copy link

Contributor

miss-islington commentedNov 30, 2022

Sorry @maggyero and@rhettinger, I had trouble checking out the3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 9628136fac997847b4662e6a17faf06d2a0507eb 3.11

miss-islington assignedrhettinger

Nov 30, 2022

rhettinger added needs backport to 3.11only security fixes and removed needs backport to 3.11only security fixes labels

Nov 30, 2022

Copy link

Contributor

miss-islington commentedNov 30, 2022

Thanks @maggyero for the PR, and@rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

Copy link

bedevere-bot commentedNov 30, 2022

GH-99909 is a backport of this pull request to the3.11 branch.

bedevere-bot removed the needs backport to 3.11only security fixes label

Nov 30, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Nov 30, 2022

bpo-47220: Document the optional callback parameter of weakref.WeakMe…

eda7e37

…thod (pythonGH-25491)(cherry picked from commit9628136)Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

miss-islington added a commit that referenced this pull request

Nov 30, 2022

bpo-47220: Document the optional callback parameter of weakref.WeakMe…

90701eb

…thod (GH-25491)(cherry picked from commit9628136)Co-authored-by: Géry Ogam <gery.ogam@gmail.com>

Copy link

ContributorAuthor

geryogam commentedNov 30, 2022

Thanks for the review!

geryogam deleted the patch-25 branch

November 30, 2022 20:00

carljm added a commit to carljm/cpython that referenced this pull request

Dec 1, 2022

Merge branch 'main' into fixinspect

12f7659

* main: (112 commits)pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)pythongh-89189: More compact range iterator (pythonGH-27986)  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)pythonGH-99877)  Fix typo in exception message in `multiprocessing.pool` (python#99900)pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)pythonGH-81057: remove static state from suggestions.c (python#99411)  Improve zip64 limit error message (python#95892)pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)pythongh-82836: fix private network check (python#97733)  Docs: improve accuracy of socketserver reference (python#24767)  ...