NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

bpo-43857: Improve the AttributeError message when deleting a missing attribute#25424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 13 commits intopython:mainfromgeryogam:patch-24

May 5, 2022

Merged

bpo-43857: Improve the AttributeError message when deleting a missing attribute#25424

JelleZijlstra merged 13 commits intopython:mainfromgeryogam:patch-24

May 5, 2022

Conversation

Copy link

Contributor

geryogam commentedApr 15, 2021•
edited by JelleZijlstra
Loading

https://bugs.python.org/issue43857

#88023

Fix the AttributeError message for deletion of a missing attribute

014e47d

the-knights-who-say-ni added the CLA signed label

Apr 15, 2021

bedevere-bot added the awaiting review label

Apr 15, 2021

Copy link

github-actionsbot commentedJun 3, 2021

This PR is stale because it has been open for 30 days with no activity.

github-actionsbot added the staleStale PR or inactive for long period of time. label

Jun 3, 2021

Merge branch 'main' into patch-24

375bf08

JelleZijlstra reviewed

May 3, 2022

View reviewed changes

Copy link

Member

JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree with this idea. Could you add a NEWS entry and a unit test that exercises this message?

(I promise I'm not stalking you, I just opened page 24 of the open PRs and found this one :) .)

geryogam added3 commits

May 4, 2022 11:11

Remove duplicate test (seepython#25863)

42da011

Add tests of error messages for attribute access

e8a7b27

Create 2022-05-04-11-37-20.bpo-43857.WuX8p3.rst

4b63ada

geryogam changed the title~~bpo-43857: Fix the AttributeError message for deletion of a missing attribute~~bpo-43857: Improve the AttributeError message when deleting a missing attribute

May 4, 2022

JelleZijlstra reviewed

May 4, 2022

View reviewed changes

Lib/test/test_class.py OutdatedShow resolvedHide resolved

JelleZijlstra self-assigned this

May 4, 2022

geryogam added2 commits

May 4, 2022 17:57

Restore a test incorrectly removed

ad05ba3

Update test_class.py

935eea5

JelleZijlstra approved these changes

May 4, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

May 4, 2022

Copy link

ContributorAuthor

geryogam commentedMay 4, 2022

Thanks@JelleZijlstra, but please don’t merge right now as some tests are failing. I am going to work on it in the next few hours. I’ll let you know when it works.

Update dictobject.c

1cb97fc

geryogam requested review frommethane andmarkshannon ascode owners

May 4, 2022 17:23

geryogam added4 commits

May 4, 2022 21:04

Update object.c

8dd6bb0

Update object.c

128d6e5

Update dictobject.c

e8f2cc7

Update object.c

4391f88

Copy link

ContributorAuthor

geryogam commentedMay 4, 2022•
edited
Loading

Not only objects but alsotype objects have inconsistentAttributeError messages between missing attribute retrieval and deletion:

$python3Python3.9.12 (main,Mar262022,15:52:10) [Clang13.0.0 (clang-1300.0.29.30)]ondarwinType"help","copyright","credits"or"license"formoreinformation.>>>classA:pass...>>>A.xTraceback (mostrecentcalllast):File"<stdin>",line1,in<module>AttributeError:typeobject'A'hasnoattribute'x'>>>delA.xTraceback (mostrecentcalllast):File"<stdin>",line1,in<module>AttributeError:x>>>A().xTraceback (mostrecentcalllast):File"<stdin>",line1,in<module>AttributeError:'A'objecthasnoattribute'x'>>>delA().xTraceback (mostrecentcalllast):File"<stdin>",line1,in<module>AttributeError:x

Compare that with PyPy for which the messages are consistent (well almost,'type' object has no attribute 'x' should betype object 'A' has no attribute 'x' fordel A.x):

$pypy3Python3.7.13 (7e0ae751533460d5f89f3ac48ce366d8642d1db5,Apr262022,09:31:20)[PyPy7.3.9withGCCAppleLLVM13.0.0 (clang-1300.0.29.30)]ondarwinType"help","copyright","credits"or"license"formoreinformation.>>>>classA:pass>>>>>>>>A.xTraceback (mostrecentcalllast):File"<stdin>",line1,in<module>AttributeError:typeobject'A'hasnoattribute'x'>>>>delA.xTraceback (mostrecentcalllast):File"<stdin>",line1,in<module>AttributeError:'type'objecthasnoattribute'x'>>>>A().xTraceback (mostrecentcalllast):File"<stdin>",line1,in<module>AttributeError:'A'objecthasnoattribute'x'>>>>delA().xTraceback (mostrecentcalllast):File"<stdin>",line1,in<module>AttributeError:'A'objecthasnoattribute'x'

Following@markshannon’s PR#28802 for Python 3.11, the message fix ofthis line in Objects/object.c provided at the early stage of this PR no longer works for objects but only fortype objects:

if (res<0&&PyErr_ExceptionMatches(PyExc_KeyError))-PyErr_SetObject(PyExc_AttributeError,name);+PyErr_Format(PyExc_AttributeError,+"'%.100s' object has no attribute '%U'",+tp->tp_name,name);

To fix the message for objects, we should also updatethis line in Objects/dictobject.c:

-PyErr_SetObject(PyExc_AttributeError,name);+PyErr_Format(PyExc_AttributeError,+"'%.100s' object has no attribute '%U'",+Py_TYPE(obj)->tp_name,name);

That way we get the same messages as in PyPy.

Finally to solve the last message inconsistency ('type' object has no attribute 'x' should betype object 'A' has no attribute 'x' fordel A.x), I replaced the last fix in Objects/object.c with this fix:

-if (res<0&&PyErr_ExceptionMatches(PyExc_KeyError))-PyErr_SetObject(PyExc_AttributeError,name);+if (res<0&&PyErr_ExceptionMatches(PyExc_KeyError)) {+if (PyType_IsSubtype(tp,&PyType_Type)) {+PyErr_Format(PyExc_AttributeError,+"type object '%.50s' has no attribute '%U'",+                          ((PyTypeObject*)obj)->tp_name,name);+         }+else {+PyErr_Format(PyExc_AttributeError,+"'%.100s' object has no attribute '%U'",+tp->tp_name,name);+         }+     }