Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
bpo-41111: Move the Py_LIMITED_API macro of xxlimited module from setup.py to xxlimited.c.#25115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| self.add(Extension('xxlimited_35', ['xxlimited_35.c'], | ||
| define_macros=[('Py_LIMITED_API','0x03050000')])) | ||
| define_macros=[('WITH_Py_LIMITED_API',1)])) | ||
| else: | ||
| # Debug mode: Build xxlimited with the full API | ||
| # (which is compatible with the limited one) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hum, I'm disappointed that CPython doesn't even support its own stable ABI in debug mode. So I createdhttps://bugs.python.org/issue43688 to also support the limited C API in debug mode.
Modules/xxlimited.c Outdated
| @@ -55,6 +55,10 @@ | |||
| pass | |||
| */ | |||
| /* xxlimited with the limited API. */ | |||
| #ifdef WITH_Py_LIMITED_API | |||
| # define Py_LIMITED_API 0x03100000 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
0x03100000 is wrong: it must be 0x030a0000 (the bug exists in the current code). I fixed the issue in my PR#25131.
Oops. I forgot to publish my review. In the meanwhile, I fixed both issues inhttps://bugs.python.org/issue43688. I created a new PR: PR#25151. |
I merged PR#25151 instead, I marked you as a co-author of my change ;-) |
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue41111