Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Minor edits to the Descriptor HowTo Guide#24901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rhettinger merged 25 commits intopython:mainfromgeryogam:patch-14
Oct 9, 2022

Conversation

@geryogam
Copy link
Contributor

@geryogamgeryogam commentedMar 17, 2021•
edited
Loading

This PR provides the following changes to theDescriptor HowTo Guide:

  • fix a typo;
  • fix a Sphinx tag preventing syntax highlighting;
  • fix a bug inClassMethod;
  • reuse an existingcls name inObject;
  • allow keyword arguments inType.__new__ andObject.__new__;
  • allow attribute lookup from a class inMember.__get__;
  • use two moresuper() inObject andType for consistency.

@geryogamgeryogam changed the titleFix a bug in the ClassMethod Python equivalent of the Descriptor HowTo GuideFix a few bugs in the Python equivalent code of the Descriptor HowTo GuideMar 19, 2021
@geryogamgeryogam changed the titleFix a few bugs in the Python equivalent code of the Descriptor HowTo GuideFix a few bugs in the Python equivalents of the Descriptor HowTo GuideMar 19, 2021
@geryogamgeryogam changed the titleFix a few bugs in the Python equivalents of the Descriptor HowTo GuideFix the Python equivalents of the Descriptor HowTo GuideMar 31, 2021
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelJun 5, 2021
@merwok
Copy link
Member

Can you open a ticket (with Raymond Hettinger in nosy) to discuss the problems you have identified here?

@geryogam
Copy link
ContributorAuthor

@merwok Thanks for the suggestion, that’s what I intended to do. The rest of the PR is completed but I still have to finish the last section on__slots__ (I completed my tests on it last year but I did not take the extra days necessary to update this PR). I will try to find a weekend shortly to do it.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@merwok
Copy link
Member

Please open a ticket to track this properly.

@geryogam
Copy link
ContributorAuthor

Please open a ticket to track this properly.

Done:#98038

@rhettingerrhettinger changed the titleImprove the Descriptor HowTo GuideMinor edits to the Descriptor HowTo GuideOct 7, 2022
@rhettingerrhettinger merged commit2d2e01a intopython:mainOct 9, 2022
@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and@rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-98112 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelOct 9, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 9, 2022
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>(cherry picked from commit2d2e01a)Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@rhettingerrhettinger added the needs backport to 3.10only security fixes labelOct 9, 2022
@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR, and@rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-98114 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelOct 9, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 9, 2022
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>(cherry picked from commit2d2e01a)Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull requestOct 9, 2022
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>(cherry picked from commit2d2e01a)Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
carljm added a commit to carljm/cpython that referenced this pull requestOct 9, 2022
* main:  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)  Auto-cancel old builds when new commit pushed to branch (python#98009)pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)
carljm added a commit to carljm/cpython that referenced this pull requestOct 9, 2022
* main: (5519 commits)  Minor edits to the Descriptor HowTo Guide (pythonGH-24901)  Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102)pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers  (python#98089)  Auto-cancel old builds when new commit pushed to branch (python#98009)pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012)pythongh-68686: Retire eptag ptag scripts (python#98064)pythongh-97922: Run the GC only on eval breaker (python#97920)  GitHub Workflows security hardening (python#96492)  Add `@ezio-melotti` as codeowner for `.github/`. (python#98079)pythongh-97913 Docs: Add walrus operator to the index (python#97921)  [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914)pythongh-97822: Fix http.server documentation reference to test() function (python#98027)pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055)pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024)pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)pythongh-57179: Add note on symlinks for os.walk (python#94799)pythongh-94808: Fix regex on exotic platforms (python#98036)pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)  ...
@geryogam
Copy link
ContributorAuthor

Thanks for the review.

@geryogamgeryogam deleted the patch-14 branchOctober 10, 2022 21:53
mpage pushed a commit to mpage/cpython that referenced this pull requestOct 11, 2022
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull requestOct 22, 2022
Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>(cherry picked from commit2d2e01a)Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@merwokmerwokmerwok left review comments

@rhettingerrhettingerrhettinger requested changes

Assignees

@rhettingerrhettinger

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@geryogam@merwok@bedevere-bot@miss-islington@rhettinger@the-knights-who-say-ni@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp