Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
[3.8] bpo-43285 Make ftplib not trust the PASV response. (GH-24838)#24881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
)bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted. This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to. This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
Sorry@gpshead, I had trouble checking out the |
bedevere-bot commentedMar 15, 2021
GH-24882 is a backport of this pull request to the3.6 branch. |
Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 15, 2021
) (pythonGH-24881)bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted. This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to. This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)Co-authored-by: Gregory P. Smith <greg@krypto.org>
bedevere-bot commentedMar 15, 2021
GH-24883 is a backport of this pull request to the3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 15, 2021
) (pythonGH-24881)bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted. This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to. This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)Co-authored-by: Gregory P. Smith <greg@krypto.org>
ned-deily pushed a commit that referenced this pull requestMar 16, 2021
…H-24881) (GH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted. This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to. This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
ned-deily pushed a commit that referenced this pull requestMar 16, 2021
…H-24881) (GH-24883)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted. This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to. This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestApr 3, 2021
) (pythonGH-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted. This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to. This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)Rebased for Python 2.7 by Michał Górny <mgorny@gentoo.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
bpo-43285: Make ftplib not trust the PASV response.
The IPv4 address value returned from the server in response to the PASV command
should not be trusted. This prevents a malicious FTP server from using the
response to probe IPv4 address and port combinations on the client network.
Instead of using the returned address, we use the IP address we're
already connected to. This is the strategy other ftp clients adopted,
and matches the only strategy available for the modern IPv6 EPSV command
where the server response must return a port number and nothing else.
For the rare user whowants this ugly behavior, set a
trust_server_pasv_ipv4_addressattribute on your
ftplib.FTPinstance to True..(cherry picked from commit0ab152c)
Co-authored-by: Gregory P. Smithgreg@krypto.org
https://bugs.python.org/issue43285