Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-43285 Make ftplib not trust the PASV response.#24838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 2 commits intopython:masterfromgpshead:ftplib_issue43285
Mar 15, 2021

Conversation

gpshead
Copy link
Member

@gpsheadgpshead commentedMar 13, 2021
edited by bedevere-bot
Loading

The IPv4 address value returned from the server in response to the PASV command
should not be trusted. This prevents a malicious FTP server from using the
response to probe IPv4 address and port combinations on the client network.

Instead of using the returned address, we use the IP address we're
already connected to. This is the strategy other ftp clients adopted,
and matches the only strategy available for the modern IPv6 EPSV command
where the server response must return a port number and nothing else.

https://bugs.python.org/issue43285

The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.
@gpsheadgpshead added type-bugAn unexpected behavior, bug, or error needs backport to 3.6 type-securityA security issue needs backport to 3.9only security fixes labelsMar 13, 2021
@gpsheadgpshead requested a review fromvstinnerMarch 13, 2021 11:56
@gpsheadgpshead self-assigned thisMar 13, 2021
@gpsheadgpshead merged commit0ab152c intopython:masterMar 15, 2021
@miss-islington
Copy link
Contributor

Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 15, 2021
bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True.(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-botbedevere-bot removed the needs backport to 3.9only security fixes labelMar 15, 2021
@bedevere-bot
Copy link

GH-24880 is a backport of this pull request to the3.9 branch.

@miss-islington
Copy link
Contributor

Sorry,@gpshead, I could not cleanly backport this to3.8 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 0ab152c6b5d95caa2dc1a30fa96e10258b5f188e 3.8

@miss-islington
Copy link
Contributor

Sorry@gpshead, I had trouble checking out the3.7 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 0ab152c6b5d95caa2dc1a30fa96e10258b5f188e 3.7

@miss-islington
Copy link
Contributor

Sorry,@gpshead, I could not cleanly backport this to3.6 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 0ab152c6b5d95caa2dc1a30fa96e10258b5f188e 3.6

gpshead added a commit to gpshead/cpython that referenced this pull requestMar 15, 2021
)bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

GH-24881 is a backport of this pull request to the3.8 branch.

miss-islington added a commit that referenced this pull requestMar 15, 2021
bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True.(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this pull requestMar 15, 2021
…H-24881)bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 15, 2021
) (pythonGH-24881)bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 15, 2021
) (pythonGH-24881)bpo-43285: Make ftplib not trust the PASV response.The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)Co-authored-by: Gregory P. Smith <greg@krypto.org>
ned-deily pushed a commit that referenced this pull requestMar 16, 2021
…H-24881) (GH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
ned-deily pushed a commit that referenced this pull requestMar 16, 2021
…H-24881) (GH-24883)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull requestApr 3, 2021
) (pythonGH-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)Rebased for Python 2.7 by Michał Górny <mgorny@gentoo.org>
rickprice added a commit to ActiveState/cpython that referenced this pull requestFeb 8, 2024
[3.6] bpo-43285 Make ftplib not trust the PASV response. (pythonGH-24838) (G……H-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit 0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
rickprice added a commit to ActiveState/cpython that referenced this pull requestFeb 8, 2024
[3.6] bpo-43285 Make ftplib not trust the PASV response. (pythonGH-24838) (G……H-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit 0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
rickprice added a commit to ActiveState/cpython that referenced this pull requestFeb 13, 2024
[3.6] bpo-43285 Make ftplib not trust the PASV response. (pythonGH-24838) (G……H-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit 0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
rickprice added a commit to ActiveState/cpython that referenced this pull requestFeb 13, 2024
[3.6] bpo-43285 Make ftplib not trust the PASV response. (pythonGH-24838) (G……H-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit 0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
rickprice added a commit to ActiveState/cpython that referenced this pull requestJun 26, 2024
[3.6] bpo-43285 Make ftplib not trust the PASV response. (pythonGH-24838) (G……H-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit 0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull requestJul 30, 2024
[3.6] bpo-43285 Make ftplib not trust the PASV response. (pythonGH-24838) (G……H-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit 0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
icanhasmath pushed a commit to ActiveState/cpython that referenced this pull requestJul 30, 2024
[3.6] bpo-43285 Make ftplib not trust the PASV response. (pythonGH-24838) (G……H-24881) (pythonGH-24882)The IPv4 address value returned from the server in response to the PASV commandshould not be trusted.  This prevents a malicious FTP server from using theresponse to probe IPv4 address and port combinations on the client network.Instead of using the returned address, we use the IP address we'realready connected to.  This is the strategy other ftp clients adopted,and matches the only strategy available for the modern IPv6 EPSV commandwhere the server response must return a port number and nothing else.For the rare user who _wants_ this ugly behavior, set a `trust_server_pasv_ipv4_address`attribute on your `ftplib.FTP` instance to True..(cherry picked from commit 0ab152c)Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit664d1d1)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner left review comments

Assignees

@gpsheadgpshead

Labels
type-bugAn unexpected behavior, bug, or errortype-securityA security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@gpshead@miss-islington@bedevere-bot@vstinner@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp