Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-43220: Accept explicit default args in required groups#24526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@keith
Copy link

@keithkeith commentedFeb 14, 2021•
edited by bedevere-bot
Loading

Previously if you had a default argument on a required mutually
exclusive group and the default was explicitly passed, it was treated
as if no value was passed. Now it accepts that value.

https://bugs.python.org/issue43220

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@keith

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Previously if you had a default argument on a required mutuallyexclusive group and the default was explicitly passed, it was treatedas if no value was passed. Now it accepts that value.
@keithkeithforce-pushed theks/bpo-43220-accept-explicit-default-args-in-required-groups branch from0b271c9 to8526023CompareFebruary 14, 2021 06:41
@rhettinger
Copy link
Contributor

Please add a NEWS entry using Blurb.

@keith
Copy link
Author

Updated!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelMar 19, 2021
@keith
Copy link
Author

Any idea who I can get to review?

@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelMar 20, 2021
@rhettingerrhettinger self-requested a reviewApril 7, 2021 08:59
@keith
Copy link
Author

@rhettinger friendly bump!

Copy link
Contributor

@furkanonderfurkanonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@keith
Copy link
Author

I merged main into this to resolve the conflict.@furkanonder should I do anything else here or is the process to wait for further review?

@serhiy-storchaka
Copy link
Member

Thank you for your contribution. It was fixed in other way by#124307.

keith reacted with thumbs up emoji

@keithkeith deleted the ks/bpo-43220-accept-explicit-default-args-in-required-groups branchSeptember 25, 2024 21:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@furkanonderfurkanonderfurkanonder approved these changes

@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@keith@the-knights-who-say-ni@rhettinger@serhiy-storchaka@furkanonder@ezio-melotti@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp