NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

bpo-41824: Add versionadded for typing.ForwardRef docs#24224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gvanrossum merged 2 commits intopython:masterfromFidget-Spinner:patch-1

Feb 9, 2021

Merged

bpo-41824: Add versionadded for typing.ForwardRef docs#24224

gvanrossum merged 2 commits intopython:masterfromFidget-Spinner:patch-1

Feb 9, 2021

Conversation

Copy link

Member

Fidget-Spinner commentedJan 15, 2021•
edited
Loading

typing.ForwardRef officially became part of the documented public API inGH-14216 (19 Jun 2019). I'm interpolating a little and guessing it landed in Python 3.7.4 according to PEP 537's schedulehttps://www.python.org/dev/peps/pep-0537/#id3.

https://bugs.python.org/issue41824

Add versionadded for typing.ForwardRef

abac0a2

Fidget-Spinner requested review fromgvanrossum andilevkivskyi ascode owners

January 15, 2021 16:29

the-knights-who-say-ni added the CLA signed label

Jan 15, 2021

bedevere-bot added docs

Documentation in the Doc dir

awaiting review labels

Jan 15, 2021

remove trailing whitespace

a29bace

Copy link

MemberAuthor

Fidget-Spinner commentedJan 15, 2021

I'm guessing this should be backported to 3.9 and 3.8 (along with skip news)?

tirkarthi added skip issue skip news labels

Jan 20, 2021

gvanrossum approved these changes

Feb 9, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Feb 9, 2021

gvanrossum merged commitda21f7b intopython:master

Feb 9, 2021

Copy link

bedevere-bot commentedFeb 9, 2021

@gvanrossum: Please replace# withGH- in the commit message next time. Thanks!

bedevere-bot removed the awaiting merge label

Feb 9, 2021

Copy link

MemberAuthor

Fidget-Spinner commentedFeb 9, 2021

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

Copy link

Member

gvanrossum commentedFeb 9, 2021

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?

Sure.

Copy link

MemberAuthor

Fidget-Spinner commentedFeb 9, 2021

@gvanrossum Thanks Guido! Should this be backported to 3.9/3.8 too?
Sure.

Sorry to trouble, can you add the labels for them please? I don't have permissions to. Though I'm not sure if the bot will pick it up if the label is appliedafter the PR is merged rather thanbefore. Either way I'm fine with manually backporting them too.

gvanrossum added needs backport to 3.8 labels

Feb 9, 2021

Copy link

Contributor

miss-islington commentedFeb 9, 2021

Thanks@Fidget-Spinner for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Copy link

Contributor

miss-islington commentedFeb 9, 2021

Thanks@Fidget-Spinner for the PR, and@gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

Copy link

Member

gvanrossum commentedFeb 9, 2021

Looks like the bot picked it up!

Copy link

Contributor

miss-islington commentedFeb 9, 2021

Sorry,@Fidget-Spinner and@gvanrossum, I could not cleanly backport this to3.8 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker da21f7b6e1fd5bd3e78931a06c5eb694f6335233 3.8

miss-islington assignedgvanrossum

Feb 9, 2021

Copy link

Contributor

miss-islington commentedFeb 9, 2021

Sorry@Fidget-Spinner and@gvanrossum, I had trouble checking out the3.9 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker da21f7b6e1fd5bd3e78931a06c5eb694f6335233 3.9