Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"#24093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JulienPalard merged 1 commit into3.8fromrevert-23828-backport-dcc997c-3.8
Jan 4, 2021

Conversation

@JulienPalard
Copy link
Member

@JulienPalardJulienPalard commentedJan 4, 2021
edited by bedevere-bot
Loading

@JulienPalard
Copy link
MemberAuthor

Hum no, a full revert is not needed, only some bits has to be reverted, let me check this in details.

…GH-23658)"This partially reverts commit02349e2, which was removingbackslashes in documentations compiled with Sphinx < 3, used forPython 3.8 and 3.9 docs.
@JulienPalardJulienPalardforce-pushed therevert-23828-backport-dcc997c-3.8 branch from43bcae7 tobcacd9dCompareJanuary 4, 2021 12:51
@JulienPalard
Copy link
MemberAuthor

@andresdelfino Same here, I kept only backslashes involved in strings, so in one hand we keep the difference as small as possible between versions (easing backports), while keeping the doc right.

I hope I picked the right ones, I still did not took the time to build it locally to visually check every change (I'm at $DAYJOB lunch break ;p).

@JulienPalardJulienPalard changed the titleRevert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"Jan 4, 2021
@JulienPalardJulienPalard added skip news docsDocumentation in the Doc dir labelsJan 4, 2021
@JulienPalardJulienPalard changed the titlebpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"[3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"Jan 4, 2021
Copy link
Contributor

@andresdelfinoandresdelfino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@andresdelfino
Copy link
Contributor

@JulienPalard I compared your changes with the ones introduced and found all of the problematic ones fixed :)

@JulienPalardJulienPalard merged commit218ed0b into3.8Jan 4, 2021
@JulienPalardJulienPalard deleted the revert-23828-backport-dcc997c-3.8 branchJanuary 4, 2021 16:19
JulienPalard added a commit to JulienPalard/cpython that referenced this pull requestJan 21, 2021
…onGH-23658)" (pythonGH-24093)This partially reverts commit02349e2, which was removingbackslashes in documentations compiled with Sphinx < 3, used forPython 3.8 and 3.9 docs.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@andresdelfinoandresdelfinoandresdelfino approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@gpsheadgpsheadAwaiting requested review from gpshead

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JulienPalard@andresdelfino@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp