Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
[3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)"#24093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
JulienPalard commentedJan 4, 2021
Hum no, a full revert is not needed, only some bits has to be reverted, let me check this in details. |
43bcae7 tobcacd9dCompareJulienPalard commentedJan 4, 2021
@andresdelfino Same here, I kept only backslashes involved in strings, so in one hand we keep the difference as small as possible between versions (easing backports), while keeping the doc right. I hope I picked the right ones, I still did not took the time to build it locally to visually check every change (I'm at $DAYJOB lunch break ;p). |
andresdelfino left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
andresdelfino commentedJan 4, 2021
@JulienPalard I compared your changes with the ones introduced and found all of the problematic ones fixed :) |
…onGH-23658)" (pythonGH-24093)This partially reverts commit02349e2, which was removingbackslashes in documentations compiled with Sphinx < 3, used forPython 3.8 and 3.9 docs.
Uh oh!
There was an error while loading.Please reload this page.
Reverts#23828 due topython/python-docs-theme#63
https://bugs.python.org/issue42822