Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-25479: add unit test for __subclasshook__ in test_abc.py#24034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 1 commit intopython:mainfromkarlcow:bpo-25479
May 12, 2021

Conversation

@karlcow
Copy link
Contributor

@karlcowkarlcow commentedJan 1, 2021•
edited by miss-islington
Loading

Converted the patch previously submitted by szymon to extend the coverage of ABC tests into a github PR.
Co-authored-by: Szymon Trapp

https://bugs.python.org/issue25479

Automerge-Triggered-By: GH:iritkatriel

Converted the patch previously submitted by szymon to extend the coverage of ABC tests into a github PR.Co-authored-by: Szymon Trapp
@iritkatriel
Copy link
Member

@karlcow Thanks for the patch. A comment on process: when responding to reviews, don't squash and force-push, just push the additional commit(s). It's nice for the reviewers to be able to see the diff, particularly for more complex PRs. When the PR is merged all the commit are squashed into one, so you don't need to do this.

karlcow and shihai1991 reacted with thumbs up emoji

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelFeb 1, 2021
@iritkatrieliritkatriel changed the titlebpo-25479: Patch to increase __subclasshook__ test coverage of abc.pybpo-25479: add unit test for __subclasshook__ in test_abc.pyMay 12, 2021
@iritkatriel
Copy link
Member

closing and reopening to get a fresh test run

@miss-islington
Copy link
Contributor

Thanks@karlcow for the PR, and@iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

karlcow reacted with hooray emoji

@miss-islington
Copy link
Contributor

Sorry@karlcow and@iritkatriel, I had trouble checking out the3.10 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 5010c044c73ee55d0fd578cfecd3f4c3f01a4140 3.10

@bedevere-bot
Copy link

GH-26063 is a backport of this pull request to the3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 12, 2021
…H-24034)Co-authored-by: Szymon Trapp(cherry picked from commit5010c04)Co-authored-by: Karl Dubost <karl+github@la-grange.net>
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull requestMay 12, 2021
…ythonGH-24034)Co-authored-by: Szymon Trapp(cherry picked from commit5010c04)Co-authored-by: Karl Dubost <karl+github@la-grange.net>
@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelMay 12, 2021
@bedevere-bot
Copy link

GH-26065 is a backport of this pull request to the3.10 branch.

iritkatriel pushed a commit that referenced this pull requestMay 12, 2021
… (GH-26063)Co-authored-by: Szymon Trapp(cherry picked from commit5010c04)Co-authored-by: Karl Dubost <karl+github@la-grange.net>
iritkatriel added a commit that referenced this pull requestMay 12, 2021
…H-24034) (GH-26065)Co-authored-by: Szymon Trapp(cherry picked from commit5010c04)Co-authored-by: Karl Dubost <karl+github@la-grange.net>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

@iritkatrieliritkatriel

Labels

skip newsstaleStale PR or inactive for long period of time.testsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@karlcow@iritkatriel@miss-islington@bedevere-bot@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp