NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

bpo-24464: Deprecate sqlite3.enable_shared_cache#24008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

berkerpeksag merged 10 commits intopython:masterfromerlend-aasland:sqlite-shared-cache

Jan 6, 2021

Merged

bpo-24464: Deprecate sqlite3.enable_shared_cache#24008

berkerpeksag merged 10 commits intopython:masterfromerlend-aasland:sqlite-shared-cache

Jan 6, 2021

Conversation

Copy link

Contributor

erlend-aasland commentedDec 30, 2020•
edited by bedevere-bot
Loading

https://bugs.python.org/issue24464

bpo-24464: Deprecate sqlite3.enable_shared_cache

4969fef

erlend-aasland requested a review fromberkerpeksag as acode owner

December 30, 2020 13:54

the-knights-who-say-ni added the CLA signed label

Dec 30, 2020

bedevere-bot added the awaiting review label

Dec 30, 2020

Add NEWS

86e95b6

Copy link

ContributorAuthor

erlend-aasland commentedDec 30, 2020

cc@ned-deily,@ronaldoussoren

Copy link

ContributorAuthor

erlend-aasland commentedDec 30, 2020

FYIhttps://sqlite.org/c3ref/enable_shared_cache.html:
"Shared cache is disabled by default. It is recommended that it stay that way. In other words, do not use this routine. This interface continues to be provided for historical compatibility, but its use is discouraged. Any use of shared cache is discouraged."

ZackerySpytz reviewed

Dec 31, 2020

View reviewed changes

Doc/whatsnew/3.10.rst Outdated

		(Contributed by Erlend E. Aasland in:issue:`42264`.)

		* ``sqlite3.enable_shared_cache`` is now deprecated, scheduled for removal in
		Python 3.12. The method is undocumented, and it's use is strongly

Copy link

Contributor

ZackerySpytzDec 31, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	Python 3.12. The method is undocumented, andit's use is strongly
	Python 3.12. The method is undocumented, andits use is strongly

It is incorrect to use a contraction here.

Also, it seems thatsqlite3.enable_shared_cache is not a method.

Copy link

ContributorAuthor

erlend-aaslandDec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also, it seems thatsqlite3.enable_shared_cache is not a method.

Correct, it's a built-in function. Good catch.

Copy link

ContributorAuthor

erlend-aaslandDec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

See7d52671. Is the new phrasing acceptable?

Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst OutdatedShow resolvedHide resolved

Erlend Egeberg Aaslandand others added4 commits

December 31, 2020 20:05

Fix typo: it's => its

13a1eb1

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Add missing punctuation mark.

f93c455

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Fix typo: it's => its

5fa5918

Co-authored-by: Zackery Spytz <zspytz@gmail.com>

Address review: it's not a method, it's a built-in function

7d52671

Copy link

ContributorAuthor

erlend-aasland commentedDec 31, 2020

PTAL,@ZackerySpytz

corona10 requested a review fromronaldoussoren

January 1, 2021 12:26

merwok reviewed

Jan 4, 2021

View reviewed changes

Lib/sqlite3/dbapi2.pyShow resolvedHide resolved

merwok reviewed

Jan 4, 2021

View reviewed changes

Lib/sqlite3/dbapi2.py OutdatedShow resolvedHide resolved

Erlend E. Aasland added2 commits

January 4, 2021 23:34

Address review: Make override reload safe

03e36d0

Address review: Improve formatting

cd11c78

merwok reviewed

Jan 4, 2021

View reviewed changes

Lib/sqlite3/dbapi2.py OutdatedShow resolvedHide resolved

Erlend E. Aaslandand others added2 commits

January 5, 2021 00:09

Improve scope

97b0452

fix url markup

cf5dca4

berkerpeksag approved these changes

Jan 6, 2021

View reviewed changes

Copy link

Member

berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

bedevere-bot added awaiting merge and removed awaiting review labels

Jan 6, 2021

Copy link

ContributorAuthor

erlend-aasland commentedJan 6, 2021

Thanks, and thanks for the markup fix,@berkerpeksag !

Copy link

Member

berkerpeksag commentedJan 6, 2021

All failed tests seem to be unrelated and flaky. Will continue with merge.

berkerpeksag merged commitddb5e11 intopython:master

Jan 6, 2021

bedevere-bot removed the awaiting merge label

Jan 6, 2021

erlend-aasland deleted the sqlite-shared-cache branch

January 6, 2021 00:36

erlend-aasland mentioned this pull request

Jan 8, 2021

bpo-24464: Fix sqlite3.enable_shared_cache() deprecation wrapper#24170

Merged

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021

bpo-24464: Deprecate sqlite3.enable_shared_cache (pythonGH-24008)

f2c6a84

This was referencedMay 9, 2022

sqlite3: remove features deprecated in 3.10#92547

Closed

gh-92547: Remove deprecated sqlite3 features#92548

Merged

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request

May 9, 2022

pythongh-92547: Remove deprecated sqlite3 features

8312697

The following sqlite3 features were deprecated in 3.10, scheduled forremoval in 3.12:- sqlite3.OptimizedUnicode (pythongh-23163)- sqlite3.enable_shared_cache (pythongh-24008)Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

erlend-aasland added a commit that referenced this pull request

May 16, 2022

gh-92547: Remove deprecated sqlite3 features (#92548)

00f22e8

The following sqlite3 features were deprecated in 3.10, scheduled forremoval in 3.12:- sqlite3.OptimizedUnicode (gh-23163)- sqlite3.enable_shared_cache (gh-24008)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

erlend-aasland mentioned this pull request

Jun 5, 2022

gh-93370 : Deprecate sqlite3.version and sqlite3.version_info#93482

Merged