Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-45772: socket.socket should be a class instead of a function#23960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
asvetlov merged 2 commits intopython:mainfromxuhdev:sock-class
Nov 13, 2021

Conversation

xuhdev
Copy link
Contributor

@xuhdevxuhdev commentedDec 27, 2020
edited by bedevere-bot
Loading

Currentlysocket.socket is documented as a function, but it is really
a class (and thus has function-like usage to construct an object). This
correction would ensure that Python projects that are interlinking
Python's documentation can properly locatesocket.socket as a type.

https://bugs.python.org/issue45772

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelJan 27, 2021
@xuhdev
Copy link
ContributorAuthor

Could someone review this, please? This should be quite quick to review.

@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelJan 28, 2021
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelFeb 28, 2021
@marsfan
Copy link

I have been running into this same issue. It would be really nice to see this fixed.

@arhadthedev
Copy link
Member

I created an entry for this pull request on bugs.python.org because most of people are there.

Actually, that's the very reason why authors should do it by themselves.

@arhadthedev
Copy link
Member

arhadthedev commentedNov 9, 2021
edited
Loading

In addition, status checks in the bottom of this GitHub page state the following:

  • bedevere/issue-number — No issue # in title or "skip issue" label found
  • bedevere/news — No news entry in Misc/NEWS.d/next/ or "skip news" label found

So you need to change a title of this issue to
image
(because that number was assigned to the entry I've created). Then you can lookamong already merged PR requests to see how other add toNEWS.d.

Edit: the bot replaced[bpo-...] with\[[bpo\](...), so I changed this part of a text with a screenshot.

@xuhdevxuhdev changed the titlesocket.socket should be a class instead of a function[bpo-45772] socket.socket should be a class instead of a functionNov 9, 2021
Currently `socket.socket` is documented as a function, but it is reallya class (and thus has function-like usage to construct an object). Thiscorrection would ensure that Python projects that are interlinkingPython's documentation can properly locate `socket.socket` as a type.
@xuhdevxuhdev changed the title[bpo-45772] socket.socket should be a class instead of a functionbpo-45772: socket.socket should be a class instead of a functionNov 9, 2021
@xuhdev
Copy link
ContributorAuthor

Thanks@arhadthedev , I've updated the PR.

arhadthedev reacted with thumbs up emoji

@terryjreedy
Copy link
Member

@marsfan add your supporting comment on the issue, with explanation if possible.

@asvetlovasvetlov merged commit4c792f3 intopython:mainNov 13, 2021
@miss-islington
Copy link
Contributor

Thanks@xuhdev for the PR, and@asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-29542 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelNov 13, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 13, 2021
…honGH-23960)* bpo-45772: socket.socket should be a class instead of a functionCurrently `socket.socket` is documented as a function, but it is reallya class (and thus has function-like usage to construct an object). Thiscorrection would ensure that Python projects that are interlinkingPython's documentation can properly locate `socket.socket` as a type.(cherry picked from commit4c792f3)Co-authored-by: Hong Xu <hong@topbug.net>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 13, 2021
…honGH-23960)* bpo-45772: socket.socket should be a class instead of a functionCurrently `socket.socket` is documented as a function, but it is reallya class (and thus has function-like usage to construct an object). Thiscorrection would ensure that Python projects that are interlinkingPython's documentation can properly locate `socket.socket` as a type.(cherry picked from commit4c792f3)Co-authored-by: Hong Xu <hong@topbug.net>
@bedevere-botbedevere-bot removed the needs backport to 3.9only security fixes labelNov 13, 2021
@bedevere-bot
Copy link

GH-29543 is a backport of this pull request to the3.9 branch.

@bedevere-bot
Copy link

GH-29544 is a backport of this pull request to the3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestNov 13, 2021
…honGH-23960)* bpo-45772: socket.socket should be a class instead of a functionCurrently `socket.socket` is documented as a function, but it is reallya class (and thus has function-like usage to construct an object). Thiscorrection would ensure that Python projects that are interlinkingPython's documentation can properly locate `socket.socket` as a type.(cherry picked from commit4c792f3)Co-authored-by: Hong Xu <hong@topbug.net>
miss-islington added a commit that referenced this pull requestNov 13, 2021
…on (GH-23960) (GH-29542)* [bpo-45772](): socket.socket should be a class instead of a functionCurrently `socket.socket` is documented as a function, but it is reallya class (and thus has function-like usage to construct an object). Thiscorrection would ensure that Python projects that are interlinkingPython's documentation can properly locate `socket.socket` as a type.(cherry picked from commit4c792f3)Co-authored-by: Hong Xu <hong@topbug.net>Automerge-Triggered-By: GH:asvetlov
miss-islington added a commit that referenced this pull requestNov 13, 2021
GH-23960) (GH-29543)* [bpo-45772](): socket.socket should be a class instead of a functionCurrently `socket.socket` is documented as a function, but it is reallya class (and thus has function-like usage to construct an object). Thiscorrection would ensure that Python projects that are interlinkingPython's documentation can properly locate `socket.socket` as a type.(cherry picked from commit4c792f3)Co-authored-by: Hong Xu <hong@topbug.net>Automerge-Triggered-By: GH:asvetlov
remykarem pushed a commit to remykarem/cpython that referenced this pull requestDec 7, 2021
…honGH-23960)* bpo-45772: socket.socket should be a class instead of a functionCurrently `socket.socket` is documented as a function, but it is reallya class (and thus has function-like usage to construct an object). Thiscorrection would ensure that Python projects that are interlinkingPython's documentation can properly locate `socket.socket` as a type.
remykarem pushed a commit to remykarem/cpython that referenced this pull requestJan 30, 2022
…honGH-23960)* bpo-45772: socket.socket should be a class instead of a functionCurrently `socket.socket` is documented as a function, but it is reallya class (and thus has function-like usage to construct an object). Thiscorrection would ensure that Python projects that are interlinkingPython's documentation can properly locate `socket.socket` as a type.
@xuhdevxuhdev deleted the sock-class branchJanuary 10, 2025 23:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@asvetlovasvetlovasvetlov left review comments

@marsfanmarsfanmarsfan approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirstaleStale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@xuhdev@marsfan@arhadthedev@terryjreedy@miss-islington@bedevere-bot@asvetlov@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp