Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658)#23827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…GH-23658)The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..(cherry picked from commitdcc997c)Co-authored-by: Andre Delfino <adelfino@gmail.com>
andresdelfino commentedDec 21, 2020
@Mariatta perhaps we can merge this? |
ghost left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Mariatta left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks
JulienPalard commentedJan 3, 2021
As in the 3.8 and 3.9 branch we don't use the newer Sphinx, this commit drops the backslashes :( I think this should be reverted, are you ok for a revert@andresdelfino ? |
andresdelfino commentedJan 3, 2021
@JulienPalard this commit doesn't affect how the doc is rendered for 3.8/3.9, but I think it's good to have consistency with master (to prevent conflicts for future commits). |
Uh oh!
There was an error while loading.Please reload this page.
The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).
The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..
(cherry picked from commitdcc997c)
Co-authored-by: Andre Delfinoadelfino@gmail.com
Automerge-Triggered-By: GH:Mariatta