This PR is stale because it has been open for 30 days with no activity.

When this PR will be reviewed and merged?

@agiudiceandrea - Is there a way to add tests to this PR? It will be easier for a core-dev to review and merge this.

@danifus thank you very much for reviewing this PR!
I'll try to address your suggestions.

@danifus I've added both your suggested improvements.

Thanks for adding those changes!

It would be good to add some tests for this new functionality. Are you able to create a minimal test file using an external program such as 7z and then embed the bytes into a test inLib/tests/test_zipfile.py?

Here's a script that you can use to turn an arbitrary file into text that you can paste into the test:

with open('minimal_example.zip', 'rb') as fid:    data = fid.read()    out = ["data = ("]    line_len = 70    line_start = 0    for i, char in enumerate(data):        str_len = len(str(char))        if len(str(data[line_start:i])) > line_len:            out.append("    " + str(data[line_start:i]))            line_start = i    if data[line_start:]:        out.append("    " + str(data[line_start:]))    out.append(")")    print("\n".join(out))

There are a number of tests in test_zipfile.py that do something similar for various functionality

@agiudiceandrea Can I finish this issue? I ask you a question first because you're almost done.

Is there any progress?

Closing and reopening to trigger CLA check.

Hi@yeojin-dev, I apologise for replying so late. I've missed the notification of comments from this PR.
Feel free (you and or any other dev) to finish this PR add and or modifying what is needed in order to have it merged.
Unfortunately I cannot remember the details about this PR and I cannot finish it.

Seems that the task has been finished in#102566.
Maybe we should close this PR.