NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec.#23405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

miss-islington merged 8 commits intopython:masterfromshihai1991:bpo_40137_functools2

Dec 29, 2020

Merged

bpo-40137: Convert _functools module to use PyType_FromModuleAndSpec.#23405

miss-islington merged 8 commits intopython:masterfromshihai1991:bpo_40137_functools2

Dec 29, 2020

Conversation

Copy link

Member

shihai1991 commentedNov 19, 2020•
edited by miss-islington
Loading

https://bugs.python.org/issue40137

Automerge-Triggered-By: GH:encukou

shihai1991 added4 commits

May 12, 2020 13:15

test

63b68b5

update pep573 in functools extension module

2ddffb0

Merge remote-tracking branch 'origin/master' into bpo_40137_functools2

4578c7c

Convert _functools module to use PyType_FromModuleAndSpec.

7074ba6

shihai1991 requested a review fromrhettinger as acode owner

November 19, 2020 15:22

the-knights-who-say-ni added the CLA signed label

Nov 19, 2020

bedevere-bot added the awaiting review label

Nov 19, 2020

vstinner reviewed

Nov 19, 2020

View reviewed changes

Modules/_pickle.c OutdatedShow resolvedHide resolved

tiran previously requested changes

Nov 20, 2020

View reviewed changes

Modules/_functoolsmodule.c OutdatedShow resolvedHide resolved

bedevere-bot added awaiting changes and removed awaiting review labels

Nov 20, 2020

Copy link

bedevere-bot commentedNov 20, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!