Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
bpo-42406: Fix whichmodule() with multiprocessing#23403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Renato L. de F. Cunha <renatoc@br.ibm.com>
the-knights-who-say-ni commentedNov 19, 2020
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You cancheck yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i made one minor edit to mentionbpo-42406 in a comment and prefer () over .
@renatolfc: Status check is done, and it's a success ❌ . |
@renatolfc: Status check is done, and it's a success ❌ . |
2 similar comments
@renatolfc: Status check is done, and it's a success ❌ . |
@renatolfc: Status check is done, and it's a success ❌ . |
Thanks@renatolfc for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
* bpo-42406: Fix whichmodule() with multiprocessingSigned-off-by: Renato L. de F. Cunha <renatoc@br.ibm.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit8668431)Co-authored-by: Renato Cunha <renatocunha@acm.org>
bedevere-bot commentedNov 29, 2020
GH-23560 is a backport of this pull request to the3.9 branch. |
* bpo-42406: Fix whichmodule() with multiprocessingSigned-off-by: Renato L. de F. Cunha <renatoc@br.ibm.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>(cherry picked from commit8668431)Co-authored-by: Renato Cunha <renatocunha@acm.org>
bedevere-bot commentedNov 29, 2020
GH-23561 is a backport of this pull request to the3.8 branch. |
* bpo-42406: Fix whichmodule() with multiprocessingSigned-off-by: Renato L. de F. Cunha <renatoc@br.ibm.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>
Importing multiprocessing adds an alias to __main__ named __mp_main__.Inpython#23403, the Python version of whichmodule() was fixed to exclude__mp_main__. Apply the same fix to the C version of the function.
Importing multiprocessing adds an alias to __main__ named __mp_main__.Inpython#23403, the Python version of whichmodule() was fixed to exclude__mp_main__. Apply the same fix to the C version of the function.
Uh oh!
There was an error while loading.Please reload this page.
This fixes the behavior of the
pickle.whichmodule()function whenmultiprocessingis imported before thepicklemodule.Prior to this patch, the following incorrect output would be found when trying to determine the module of the (for example)
gdtrixfunction:With the patch, now we get correct behavior:
This alsofixesuqfoundation/dill#392.
Signed-off-by: Renato L. de F. Cunharenatoc@br.ibm.com
https://bugs.python.org/issue42406
Automerge-Triggered-By: GH:gpshead