Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-42327: Add PyModule_Add().#23240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedNov 11, 2020•
edited by bedevere-bot
Loading

@serhiy-storchakaserhiy-storchaka changed the titleAdd PyModule_Add().bpo-42327: Add PyModule_Add().Nov 11, 2020
@serhiy-storchakaserhiy-storchaka marked this pull request as ready for reviewNovember 14, 2020 17:47
@pablogsalpablogsal added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 14, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@pablogsal for commit17279ae 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelNov 14, 2020
Copy link
Member

@tirantiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could you please move your changes of_ssl.c to another PR? This PR will cause major conflicts with two of my PRs.

I also like to get your opinion onhttps://discuss.python.org/t/define-module-constants-in-pymoduledef/5749 . I have suggested a radically different approach for module constant initialization that is even more convenient thanPyModule_Add().

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@serhiy-storchaka
Copy link
MemberAuthor

I will most likely break this PR into several parts and merge them separately. It grew more than I expected because for each modified module I fixed all potential leaks, and some module expose many constants.

tiran reacted with thumbs up emoji

@serhiy-storchaka
Copy link
MemberAuthor

Created#23443 which does not include large changes.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelDec 22, 2020
@rhettingerrhettinger removed their request for reviewMay 3, 2022 06:14
@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelJul 31, 2022
@serhiy-storchaka
Copy link
MemberAuthor

Split and merged as a number of smaller PRs.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tirantirantiran requested changes

@abalkinabalkinAwaiting requested review from abalkinabalkin is a code owner

@pablogsalpablogsalAwaiting requested review from pablogsal

@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@serhiy-storchaka@bedevere-bot@tiran@pablogsal@the-knights-who-say-ni@ezio-melotti
[8]ページ先頭
©2009-2025 Movatter.jp