Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-14935: Remove static state from the _csv module#23224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 12 commits intopython:masterfromencukou:pep-573-walker-and-csv
Dec 15, 2020

Conversation

@encukou
Copy link
Member

@encukouencukou commentedNov 10, 2020•
edited by bedevere-bot
Loading

This merges code/ideas fromgh-20974 andgh-16078, and uses the new_PyType_GetModuleByDef.

Co-authored-by: Marcel Plchgmarcel.plch@gmail.com
Co-authored-by: Eddie Elizondoeduardo.elizondorueda@gmail.com
Co-authored-by: Hai Shishihai1992@gmail.com

https://bugs.python.org/issue14935

Uses code from:python#16078Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com>Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>Co-authored-by: Hai Shi <shihai1992@gmail.com>
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. IMO the code is cleaner with your changes, thanks.

I just added a minor coding style remark, feel free to ignore it ;-)


PyType_SpecWriter_Type_spec= {
"_csv.writer",
sizeof(WriterObj),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

maybe use ".m_xxx = xxx" syntax here, as you did for the other spec below. Same remark for Reader_Type_spec.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks.

Copy link
Member

@shihai1991shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have no other comments, so LGTM.

@encukouencukou merged commit6a02b38 intopython:masterDec 15, 2020
@encukouencukou deleted the pep-573-walker-and-csv branchDecember 15, 2020 14:14
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 13, 2021
Uses code from:python#16078Co-authored-by: Marcel Plch <gmarcel.plch@gmail.com>Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>Co-authored-by: Hai Shi <shihai1992@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@shihai1991shihai1991shihai1991 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@encukou@vstinner@shihai1991@the-knights-who-say-ni@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp