NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-85160: Optimized singledispatchmethod access (noticeable improvement).#23213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

mental32 wants to merge2 commits intopython:mainfrommental32:bpo-40988

Closed

gh-85160: Optimized singledispatchmethod access (noticeable improvement).#23213

mental32 wants to merge2 commits intopython:mainfrommental32:bpo-40988

Conversation

Copy link

Contributor

mental32 commentedNov 10, 2020•
edited by bedevere-bot
Loading

I benchmarked using the following code:

fromfunctoolsimportsingledispatch,singledispatchmethodimporttimeitclassTest:@singledispatchmethoddefgo(self,item,arg):print('general')@go.registerdef_(self,item:int,arg):returnitem+arg@singledispatchdefgo(item,arg):print('general')@go.registerdef_(item:int,arg):returnitem+argprint('m',timeit.timeit('t.go(1, 1)',globals={'t':Test()}))print('s',timeit.timeit('go(1, 1)',globals={'go':go}))

And got the following output:

mental@felix ~/D/o/cpython (master)> ./python /tmp/fdsm.pym 4.794188453000061s 0.9868643390000216mental@felix ~/D/o/cpython (master)> git checkout 40988Switched to branch '40988'mental@felix ~/D/o/cpython (40988) [1]> ./python /tmp/fdsm.pym 1.3791182540007867s 0.9882650030003788

I'm still curious if access could be further optimized clueless when it comes to ideas 😅

https://bugs.python.org/issue40988

Issue:singledispatchmethod significantly slower than singledispatch #85160

bpo-40988: Optimized singledispatchmethod access.

04fe64e

mental32 requested a review fromrhettinger as acode owner

November 10, 2020 05:12

the-knights-who-say-ni added the CLA signed label

Nov 10, 2020

bedevere-bot added the awaiting review label

Nov 10, 2020

mental32 changed the title~~bpo-40988: Optimized singledispatchmethod access (3x ish improvement).~~bpo-40988: Optimized singledispatchmethod access (noticeable improvement).

Nov 10, 2020

Copy link

github-actionsbot commentedDec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actionsbot added the staleStale PR or inactive for long period of time. label

Dec 16, 2020

Copy link

CaselIT commentedDec 16, 2020

Comment to avoid closure

github-actionsbot removed the staleStale PR or inactive for long period of time. label

Dec 17, 2020

Copy link

github-actionsbot commentedJan 16, 2021

This PR is stale because it has been open for 30 days with no activity.

github-actionsbot added the staleStale PR or inactive for long period of time. label

Jan 16, 2021

Copy link

ContributorAuthor

mental32 commentedJan 16, 2021

@rhettinger sorry for bothering you but do you have enough bandwidth to review this or can you defer to someone else?

github-actionsbot removed the staleStale PR or inactive for long period of time. label

Jan 17, 2021

Copy link

CaselIT commentedSep 17, 2021

Not sure if there is anything we should do to allow this to be reviewed

rhettinger removed their request for review

May 3, 2022 06:14

MaxwellDupre approved these changes

May 14, 2022

View reviewed changes

Copy link

Contributor

MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

On my slow system more modest, but an improvement:
11.24
2.27
to
5.83
3.54
I not that this is built on 3.10.0a2+ so there maybe further speed improvements when 3.11/3.12 is released. So a worthwhile change.

bedevere-bot added awaiting core review and removed awaiting review labels

May 14, 2022

Copy link

TeamSpen210 commentedMay 14, 2022

Since this is something that’ll have observable effects on objects, should this be documented? If you’re introspecting your objects, or are say concerned about memory usage it might be surprising behaviour.

ezio-melotti removed the CLA signed label

Jul 13, 2022

eendebakpt mentioned this pull request

Aug 31, 2022

Triage the open "performance" issues on cpython repofaster-cpython/ideas#440

Closed

iritkatriel added the performancePerformance or resource usage label

Aug 31, 2022

CaselITmannequin mentioned this pull request

Sep 9, 2022

singledispatchmethod significantly slower than singledispatch#85160

Closed

Merge branch 'main' intobpo-40988

fc72bea

AlexWaygood changed the title~~bpo-40988: Optimized singledispatchmethod access (noticeable improvement).~~gh-85160: Optimized singledispatchmethod access (noticeable improvement).

Jul 5, 2023

AlexWaygood mentioned this pull request

Jul 5, 2023

gh-85160: improve performance of singledispatchmethod#106448

Closed

Copy link

Contributor

eendebakpt commentedJul 5, 2023

@mental32 @AlexWaygood By accident I created an independent implementation of the singledispatchmethod improvement. In#106448 I added a performance comparison of this PR and the other one. I also added a test for the case of a class with slots (commit4e068d4). Feel free to pull that one into this branch.

Both branches give a performance improvement over current main. Hopefully one of them gets accepted.

eendebakpt reviewed

Jul 5, 2023

View reviewed changes

Lib/functools.py

Comment on lines +957 to +963

		ifself.attrnameisnotNone:
		attrname=self.attrname

		try:
		obj.__dict__[attrname]=_method
		exceptAttributeError:
		pass# not all objects have __dict__ (e.g. class defines slots)

Copy link

Contributor

eendebakptJul 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	ifself.attrnameisnotNone:
	attrname=self.attrname

	try:
	obj.__dict__[attrname]=_method
	exceptAttributeError:
	pass# not all objects have __dict__ (e.g. class defines slots)
	ifself.attrnameisnotNone:
	try:
	obj.__dict__[self.attrname]=_method
	exceptAttributeError:
	pass# not all objects have __dict__ (e.g. class defines slots)

corona10 self-assigned this

Jul 21, 2023

eendebakpt mentioned this pull request

Jul 23, 2023

gh-85160: improve performance of singledispatchmethod#107148

Merged

Copy link

ContributorAuthor

mental32 commentedJul 26, 2023•
edited
Loading

@eendebakpt thank you for continuing with this!

for any changes or merging that you would like to see done is it okay for me to say "do whatever you need to do :)" and defer to you? (including closing this PR if the other one is sufficient in perf improvements) I don't think I have the time to pay attention to this is all