Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-42264: Deprecate sqlite3.OptimizedUnicode#23163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 11 commits intopython:masterfromerlend-aasland:bpo-42264
Nov 17, 2020

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedNov 5, 2020•
edited
Loading

Fixes#86430

@erlend-aaslanderlend-aasland changed the titlebpo-42264: Deprecate OptimizedUnicodebpo-42264: Deprecate sqlite3.OptimizedUnicodeNov 5, 2020
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

erlend-aasland and hafizulsaat92 reacted with hooray emoji
@erlend-aasland
Copy link
ContributorAuthor

Thanks for reviewing,@serhiy-storchaka!

@serhiy-storchaka
Copy link
Member

And it could be good idea to add tests for filename to all existing deprecation tests.

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
ContributorAuthor

And it could be good idea to add tests for filename to all existing deprecation tests.

I agree. I can open an issue for it.

serhiy-storchaka reacted with thumbs up emoji

@erlend-aasland
Copy link
ContributorAuthor

And it could be good idea to add tests for filename to all existing deprecation tests.

There's a lot:

bash$ grep -r "DeprecationWarning" Lib/test | grep -v " as " | wc -l                                                                                                               (master)cpython.git     519

Erlend Egeberg Aaslandand others added2 commitsNovember 5, 2020 20:11
Co-authored-by: Victor Stinner <vstinner@python.org>
@erlend-aasland
Copy link
ContributorAuthor

PTAL,@vstinner

@erlend-aasland
Copy link
ContributorAuthor

FYI, Ubuntu CI hangs again:
test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)!

@vstinner
Copy link
Member

test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)!

It is a know issuehttps://bugs.python.org/issue42142

You can ignore it. When it happens, I simply re-run the job until it pass.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good, it's way better! More comments.

erlend-aasland reacted with hooray emoji
Erlend E. Aaslandand others added2 commitsNovember 6, 2020 20:08
Use the same text as the What's New entry.
Co-authored-by: Victor Stinner <vstinner@python.org>
@erlend-aasland
Copy link
ContributorAuthor

Please take another look,@vstinner.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@serhiy-storchaka: Do you want to double check this PR?

erlend-aasland reacted with hooray emoji
@erlend-aasland
Copy link
ContributorAuthor

@serhiy-storchaka Will you merge this after double checking, or will that be up to another core dev to decide?

@serhiy-storchakaserhiy-storchaka merged commita1f401a intopython:masterNov 17, 2020
@erlend-aaslanderlend-aasland deleted the bpo-42264 branchNovember 17, 2020 19:55
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 13, 2021
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestMay 9, 2022
The following sqlite3 features were deprecated in 3.10, scheduled forremoval in 3.12:- sqlite3.OptimizedUnicode (pythongh-23163)- sqlite3.enable_shared_cache (pythongh-24008)Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull requestMay 16, 2022
The following sqlite3 features were deprecated in 3.10, scheduled forremoval in 3.12:- sqlite3.OptimizedUnicode (gh-23163)- sqlite3.enable_shared_cache (gh-24008)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksag

+1 more reviewer

@hafizulsaat92hafizulsaat92hafizulsaat92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@erlend-aasland@bedevere-bot@serhiy-storchaka@vstinner@hafizulsaat92@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp