NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-103092: Prep curses module for multi-phase init#23091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

koubaa wants to merge3 commits intopython:mainfromkoubaa:bpo-1635741-curses-prep

Closed

gh-103092: Prep curses module for multi-phase init#23091

koubaa wants to merge3 commits intopython:mainfromkoubaa:bpo-1635741-curses-prep

Conversation

Copy link

Contributor

koubaa commentedNov 2, 2020•
edited by bedevere-appbot
Loading

https://bugs.python.org/issue1635741

Issue:Isolate Stdlib Extension Modules #103092

the-knights-who-say-ni added the CLA signed label

Nov 2, 2020

bedevere-bot added the awaiting review label

Nov 2, 2020

shihai1991 reviewed

Nov 2, 2020

View reviewed changes

Modules/_cursesmodule.c OutdatedShow resolvedHide resolved

shihai1991 reviewed

Nov 2, 2020

View reviewed changes

Modules/_cursesmodule.c OutdatedShow resolvedHide resolved

shihai1991 reviewed

Nov 2, 2020

View reviewed changes

Modules/_cursesmodule.cShow resolvedHide resolved

Copy link

Member

shihai1991 commentedNov 2, 2020

cc@vstinner @corona10

koubaa marked this pull request as draft

November 3, 2020 00:31

koubaa marked this pull request as ready for review

November 4, 2020 02:37

Copy link

ContributorAuthor

koubaa commentedNov 4, 2020

@vstinner @corona10 @shihai1991 please review

vstinner reviewed

Nov 4, 2020

View reviewed changes

Modules/_cursesmodule.c OutdatedShow resolvedHide resolved

Copy link

github-actionsbot commentedDec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

github-actionsbot added the staleStale PR or inactive for long period of time. label

Dec 16, 2020

koubaa added3 commits

February 28, 2021 12:30

Prep curses module for multi-phase init

ab3c3f3

fix issues with CI

ddfb744

remove PyImport_ImportModuleNoBlock

0dc705b

koubaa force-pushed thebpo-1635741-curses-prep branch fromc96930b to0dc705bCompare

February 28, 2021 18:31

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"return NULL;" is enough: you should remove the error label. An error label is used when you need to clean up things, it's not the case here. Same remark at the bottom of the file.

Modules/_cursesmodule.c

		return NULL;
		}

		static void *PyCurses_API[PyCurses_API_pointers];

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There are warnings on the PR, like ‘PyCurses_API’ defined but not used [-Wunused-variable].

Copy link

Member

iritkatriel commentedApr 11, 2022

https://bugs.python.org/issue1635741 is closed. What is the status of this PR?

Copy link

Member

vstinner commentedApr 19, 2022

The change is still relevant, but should use a new issue number.

Moreover, the SC asked to put the conversion of static types to heap types on hold.@encukou and@erlend-aasland wrotehttps://peps.python.org/pep-0687/ which may unblock the situation but it's still a draft.