Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-26131: deprecate the use of load_module()#22905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One suggestion. There are also test failures.
Uh oh!
There was an error while loading.Please reload this page.
bedevere-bot commentedOct 23, 2020
When you're done making the requested changes, leave the comment: |
I have made the requested changes; please review again |
bedevere-bot commentedOct 23, 2020
Thanks for making the requested changes! @warsaw: please review the changes made to this pull request. |
This is going to require implementing |
Uh oh!
There was an error while loading.Please reload this page.
Deprecating the use of
load_module()
requires two parts:load_module()
implementations are deprecated.load_module()
as a fallback forexec_module()
trigger anImportWarning
.This makes sure that either direct use of the method or indirect use by the import system raisessome warning.
The method itself has been documented as deprecated since Python 3.6 and has been superceded by exec_module().
https://bugs.python.org/issue26131