Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
bpo-36876: Fix the C analyzer tool.#22841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
bpo-36876: Fix the C analyzer tool.#22841
Uh oh!
There was an error while loading.Please reload this page.
Conversation
pablogsal commentedOct 21, 2020
I would recommend checking with the buildbot label before merging as some of the refleaks were reported previously with the old analyzer (although most were false positives). |
ericsnowcurrently commentedOct 23, 2020
FWIW, this PR removes all the tool's tests, except for the one we care about (and that one is currently disabled). So refleaks shouldn't be a problem. 😄 |
The original tool wasn't working right and it was simpler to create a new one, partially re-using some of the old code. At this point the tool runs properly on the master. (Try: ./python Tools/c-analyzer/c-analyzer.py analyze.) It take ~40 seconds on my machine to analyze the full CPython code base.Note that we'll need to iron out some OS-specific stuff (e.g. preprocessor). We're okay though since this tool isn't used yet in our workflow. We will also need to verify the analysis results in detail before activating the check in CI, though I'm pretty sure it's close.https://bugs.python.org/issue36876
Uh oh!
There was an error while loading.Please reload this page.
The original tool wasn't working right and it was simpler to create a new one, partially re-using some of the old code. At this point the tool runs properly on the master. (Try:
./python Tools/c-analyzer/c-analyzer.py analyze.) It take ~35 seconds on my machine to analyze the full CPython code base.Note that we'll need to iron out some OS-specific stuff (e.g. preprocessor). We're okay though since this tool isn't used yet in our workflow. We will also need to verify the analysis results in detail before activating the check in CI, though I'm pretty sure it's close.
https://bugs.python.org/issue36876