Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-42047: DragonFlyBSD thread native id support.#22714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 8 commits intopython:mainfromdevnexen:dfbsd_build_fix
May 18, 2022

Conversation

@devnexen
Copy link
Contributor

@devnexendevnexen commentedOct 15, 2020•
edited by bedevere-bot
Loading

Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, just one minor nitpick on news

Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelDec 16, 2020
@devnexen
Copy link
ContributorAuthor

ping :)

@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelDec 17, 2020
Co-authored-by: Victor Stinner <vstinner@python.org>
@erlend-aasland
Copy link
Contributor

Please also update theavailability annotation ofget_native_id in the docs:

  • Doc/library/_thread.rst
  • Doc/library/threading.rst

Seegh-13624 for inspiration :)

@erlend-aaslanderlend-aasland self-assigned thisMay 18, 2022
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please resolve#22714 (comment)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@devnexen
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@erlend-aasland,@Fidget-Spinner: please review the changes made to this pull request.

@erlend-aasland
Copy link
Contributor

Thanks,@devnexen!

@vstinner
Copy link
Member

Maybe POSIX should do something and create a portable API for this function :-)

erlend-aasland reacted with laugh emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@devnexen@erlend-aasland@bedevere-bot@vstinner@Fidget-Spinner@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp