Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-86155: Fix htmlparser "unclosed script tag causes data loss"#22658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 8 commits intopython:mainfromwaylan:htmlparser
May 10, 2025

Conversation

waylan
Copy link
Contributor

@waylanwaylan commentedOct 12, 2020•
edited by bedevere-bot
Loading

When calling .close() the htmlparser should flush all remaining content,
even when that content is in an unclosed script or style tag.

https://bugs.python.org/issue41989

When calling .close() the htmlparser should flush all remaining content,even when that content is in an unclosed script or style tag.
@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@waylan

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@waylanwaylan changed the titlebpo:41989 Fix htmlparser "unclosed script tag causes data loss"bpo-41989 Fix htmlparser "unclosed script tag causes data loss"Oct 12, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelDec 17, 2020
@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelJul 30, 2022
@bedevere-bot
Copy link

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

@arhadthedevarhadthedev changed the titlebpo-41989 Fix htmlparser "unclosed script tag causes data loss"gh-86155: Fix htmlparser "unclosed script tag causes data loss"Feb 13, 2023
@arhadthedevarhadthedev added the stdlibPython modules in the Lib dir labelFeb 13, 2023
@arhadthedev
Copy link
Member

@ezio-melotti (as an html expert)

ezio-melotti reacted with eyes emoji

@python-cla-bot
Copy link

python-cla-botbot commentedApr 18, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 10, 2025
@serhiy-storchakaserhiy-storchakaenabled auto-merge (squash)May 10, 2025 16:53
@serhiy-storchakaserhiy-storchaka merged commit53383e9 intopython:mainMay 10, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks@waylan for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

waylan reacted with thumbs up emoji

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2025
…TMLParser (pythonGH-22658)When calling .close() the HTMLParser should flush all remaining content,even when that content is in an unclosed script or style tag.(cherry picked from commit53383e9)Co-authored-by: Waylan Limberg <waylan.limberg@icloud.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2025
…TMLParser (pythonGH-22658)When calling .close() the HTMLParser should flush all remaining content,even when that content is in an unclosed script or style tag.(cherry picked from commit53383e9)Co-authored-by: Waylan Limberg <waylan.limberg@icloud.com>
@bedevere-app
Copy link

GH-133844 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 10, 2025
@bedevere-app
Copy link

GH-133845 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 10, 2025
serhiy-storchaka pushed a commit that referenced this pull requestMay 10, 2025
…HTMLParser (GH-22658) (GH-133845)When calling .close() the HTMLParser should flush all remaining content,even when that content is in an unclosed script or style tag.(cherry picked from commit53383e9)Co-authored-by: Waylan Limberg <waylan.limberg@icloud.com>
serhiy-storchaka pushed a commit that referenced this pull requestMay 10, 2025
…HTMLParser (GH-22658) (GH-133844)When calling .close() the HTMLParser should flush all remaining content,even when that content is in an unclosed script or style tag.(cherry picked from commit53383e9)Co-authored-by: Waylan Limberg <waylan.limberg@icloud.com>
@waylanwaylan deleted the htmlparser branchMay 12, 2025 15:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees
No one assigned
Labels
stdlibPython modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@waylan@the-knights-who-say-ni@bedevere-bot@arhadthedev@serhiy-storchaka@ezio-melotti@hauntsaninja
[8]ページ先頭
©2009-2025 Movatter.jp