NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

bpo-41916: allow cross-compiled python to have -pthread set for CXX#22525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gpshead merged 1 commit intopython:mainfromvirtuald:allow-cxx-pthread-override

Jan 5, 2023

Merged

bpo-41916: allow cross-compiled python to have -pthread set for CXX#22525

gpshead merged 1 commit intopython:mainfromvirtuald:allow-cxx-pthread-override

Jan 5, 2023

Conversation

Copy link

Contributor

virtuald commentedOct 3, 2020•
edited by bedevere-bot
Loading

When cross-compiling, the compile/run test for -pthread always fails so -pthread will never be automatically set without an override from the cache. ac_cv_pthread can already be overridden, so do the same thing for ac_cv_cxx_thread.

I've validated that my cross-compiled python has the variables set now when configured via:

   ./configure --host=$TARGET_HOST --build=$BUILD_HOST --prefix=$PREFIX \        --disable-ipv6 --enable-unicode=ucs4 \        ac_cv_file__dev_ptmx=no ac_cv_file__dev_ptc=no \        ac_cv_have_long_long_format=yes \        ac_cv_pthread_is_default=no ac_cv_pthread=yes ac_cv_cxx_thread=yes; \

I now get as expected:

>>> import pprint, distutils.sysconfig>>> pprint.pprint({i: distutils.sysconfig.get_config_vars(i)[0] for i in ('CC', 'CXX', 'LDSHARED')}){'CC': 'arm-frc2020-linux-gnueabi-gcc -pthread', 'CXX': 'arm-frc2020-linux-gnueabi-c++ -pthread', 'LDSHARED': 'arm-frc2020-linux-gnueabi-gcc -pthread -shared'}

I haven't yet checked to see if it all works quite yet, will do later today.

https://bugs.python.org/issue41916

the-knights-who-say-ni added the CLA signed label

Oct 3, 2020

bedevere-bot added the awaiting review label

Oct 3, 2020

Copy link

ContributorAuthor

virtuald commentedOct 6, 2020

Some testing indicates that this worked without issues. Given that the tests all seem to pass on CI, I think this is good to go.

virtuald mentioned this pull request

Oct 17, 2020

-pthread not set in cross-compiled python gcc flagsbenfogle/crossenv#36

Open

virtuald mentioned this pull request

Oct 24, 2020

Cross-compile from sources for Yocto/Linuxscipy/scipy#8571

Closed

Copy link

ContributorAuthor

virtuald commentedOct 24, 2020

I have confirmed that this does fix the issues I was running into, and my cross compiled packages seem to be fine.

FFY00 approved these changes

Mar 4, 2022

View reviewed changes

Copy link

Member

FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This fix looks correct.@jaraco could you have a look?

bedevere-bot added awaiting core review and removed awaiting review labels

Mar 4, 2022

Copy link

ContributorAuthor

virtuald commentedMar 4, 2022

I've been using it to build python 3.9.x and more recently python 3.10.x without any issues.

Copy link

Member

FFY00 commentedMar 4, 2022

Perhaps, just add a news item to make it quicker to merge. I think the code is good, it is just missing a news entry.

Copy link

Contributor

kumaraditya303 commentedMar 4, 2022

You can usehttps://blurb-it.herokuapp.com/ to add a news fragment.

virtuald force-pushed theallow-cxx-pthread-override branch from6ff346a to0fdc88dCompare

March 4, 2022 15:48

Copy link

Member

jaraco commentedApr 4, 2022

I'm afraid I don't have a lot of experience with this aspect of CPython. Perhaps@ambv could review or suggest a reviewer?

Copy link

ContributorAuthor

virtuald commentedApr 4, 2022•
edited by bedevere-bot
Loading

FWIW, I've been usingthe patch to cross-compile python for use in CI since I've made the patch.

ezio-melotti removed the CLA signed label

Jul 13, 2022

virtuald force-pushed theallow-cxx-pthread-override branch from0fdc88d to77af732Compare

October 14, 2022 05:25

Copy link

ContributorAuthor

virtuald commentedOct 14, 2022

Rebased on main; integrated changes that were made in#29485

Copy link

ContributorAuthor

virtuald commentedOct 14, 2022

@tiran seems to make a lot of changes to configure.ac, perhaps they might be a better reviewer for this?

bpo-41916: allow cross-compiled python to have -pthread set for CXX

fefd3d2

When cross-compiling, the compile/run test for -pthread always fails so -pthreadwill never be automatically set without an override from the cache. ac_cv_pthreadcan already be overridden, so do the same thing for ac_cv_cxx_thread.

virtuald force-pushed theallow-cxx-pthread-override branch from77af732 tofefd3d2Compare

October 14, 2022 06:06

Copy link

Member