A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

I have made the requested changes; please review again.

@corona10 I didn't see any occurrences offloat() in test_float.py, so I added a test. Where are you saying the test already exists?

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

I didn't see any occurrences of float() in test_float.py

https://github.com/python/cpython/pull/22432/checks?check_run_id=1175574849

There was already a crash on your PR on CI phase.
So I guess that there is already in, but it looks like good to add the case ontest_float.py

@markshannon

This PR is same case from#22427

Do you think that the vectorcall is good enough to apply for float() call also from the maintenance cost view?

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbots390x RHEL8 LTO 3.x has failed when building commite8acc35.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/567/builds/758) and take a look at the build logs.
4. Check if the failure is related to this commit (e8acc35) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/567/builds/758

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

408 tests OK.

10 slowest tests:

• test_concurrent_futures: 2 min 53 sec
• test_peg_generator: 2 min 52 sec
• test_gdb: 1 min 36 sec
• test_multiprocessing_spawn: 1 min 13 sec
• test_multiprocessing_forkserver: 1 min 1 sec
• test_multiprocessing_fork: 53.5 sec
• test_asyncio: 49.1 sec
• test_signal: 47.1 sec
• test_tokenize: 34.3 sec
• test_io: 34.0 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 5 min 33 sec

Traceback (most recent call last):  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line321, in__del__self.close()  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line316, incloseself._ssl_protocol._start_shutdown()  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line590, in_start_shutdownself._abort()  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line731, in_abortself._transport.abort()  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/selector_events.py", line680, inabortself._force_close(None)  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/selector_events.py", line731, in_force_closeself._loop.call_soon(self._call_connection_lost, exc)  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/base_events.py", line746, incall_soonself._check_closed()  File"/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/base_events.py", line510, in_check_closedraiseRuntimeError('Event loop is closed')RuntimeError:Event loop is closed