NotificationsYou must be signed in to change notification settings
Fork32.2k
Star67.7k

bpo-41861: Convert sqlite3 PrepareProtocolType to heap type#22428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:masterfromerlend-aasland:fix-bpo-41861/prepareprotocol

Sep 28, 2020

Merged

bpo-41861: Convert sqlite3 PrepareProtocolType to heap type#22428

vstinner merged 1 commit intopython:masterfromerlend-aasland:fix-bpo-41861/prepareprotocol

Sep 28, 2020

Conversation

Copy link

Contributor

erlend-aasland commentedSep 27, 2020•
edited by bedevere-bot
Loading

Part 2 ofbpo-41861,@vstinner

Tested for ref. leaks using./python.exe -m test -F -r -j1 -R 3:10 test_sqlite

https://bugs.python.org/issue41861

Convert PrepareProtocolType to heap type

0c07524

erlend-aasland requested a review fromberkerpeksag as acode owner

September 27, 2020 18:39

the-knights-who-say-ni added the CLA signed label

Sep 27, 2020

bedevere-bot added the awaiting review label

Sep 27, 2020

erlend-aasland changed the title~~bpo-41861: Convert PrepareProtocolType to heap type~~bpo-41861: Convert sqlite3 PrepareProtocolType to heap type

Sep 27, 2020

vstinner reviewed

Sep 28, 2020

View reviewed changes

Modules/_sqlite/prepare_protocol.cShow resolvedHide resolved

vstinner added the skip news label

Sep 28, 2020

vstinner approved these changes

Sep 28, 2020

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

bedevere-bot added awaiting merge and removed awaiting review labels

Sep 28, 2020

vstinner merged commitcb6db8b intopython:master

Sep 28, 2020

bedevere-bot removed the awaiting merge label

Sep 28, 2020

erlend-aasland deleted the fix-bpo-41861/prepareprotocol branch

September 28, 2020 22:07

Copy link

ContributorAuthor

erlend-aasland commentedSep 28, 2020

Thanks,@vstinner ! I'll put up the next PR in a few minutes.

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Sep 29, 2020

Merge remote-tracking branch 'origin/master' into bpo_1635741_1

e3b9365

* origin/master: (113 commits)  bpo-41773: Raise exception for non-finite weights in random.choices().  (pythonGH-22441)  bpo-41873: Add vectorcall for float() (pythonGH-22432)  bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428)  bpo-41842: Add codecs.unregister() function (pythonGH-22360)  bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433)  bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337)  bpo-41870: Use PEP 590 vectorcall to speed up bool()  (pythonGH-22427)  [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340)  bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417)  bpo-41858: Clarify line in optparse doc (pythonGH-22407)  Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424)  bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415)  bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416)  Fix logging error message (pythonGH-22410)  bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395)  bpo-41775: Make 'IDLE Shell' the shell title  (python#22399)  bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)  bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387)  bpo-41833: threading.Thread now uses the target name (pythonGH-22357)  bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633)  ...