NotificationsYou must be signed in to change notification settings
Fork32.2k
Star67.7k

bpo-41861: Convert sqlite3 cache and node types to heap types#22417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 8 commits intopython:masterfromerlend-aasland:fix-bpo-41861/cache-and-node-types

Sep 27, 2020

Merged

bpo-41861: Convert sqlite3 cache and node types to heap types#22417

vstinner merged 8 commits intopython:masterfromerlend-aasland:fix-bpo-41861/cache-and-node-types

Sep 27, 2020

Conversation

Copy link

Contributor

erlend-aasland commentedSep 26, 2020•
edited
Loading

@vstinner, ref. PR#22409

https://bugs.python.org/issue41861

Erlend E. Aasland added3 commits

September 26, 2020 12:15

Convert CacheType to heap type

b3af287

Convert NodeType to heap type

c3cedc5

Add NEWS entry

a3e33bd

erlend-aasland requested a review fromberkerpeksag as acode owner

September 26, 2020 10:31

the-knights-who-say-ni added the CLA signed label

Sep 26, 2020

bedevere-bot added the awaiting review label

Sep 26, 2020

erlend-aasland changed the title~~bpo-41861: /cache and node types~~bpo-41861: Convert sqlite3 cache and node types to heap types

Sep 26, 2020

vstinner reviewed

Sep 26, 2020

View reviewed changes

Modules/_sqlite/cache.c OutdatedShow resolvedHide resolved

Misc/NEWS.d/next/Library/2020-09-26-12-16-28.bpo-41861.3xTsIp.rst OutdatedShow resolvedHide resolved

Revert "Add NEWS entry"

f1568b1

This reverts commita3e33bd.

vstinner added the skip news label

Sep 26, 2020

Erlend E. Aasland added2 commits

September 26, 2020 13:03

Use PyType_FromModuleAndSpec iso. PyType_FromSpec

cdb6e4c

Improve dealloc

6be8abc

Copy link

ContributorAuthor

erlend-aasland commentedSep 26, 2020

Thanks for your comments,@vstinner. Please take another look.

Fix dealloc for cache type as well

fad7260

erlend-aasland requested a review fromvstinner

September 26, 2020 11:46

Make node type spec static

e8be010

Copy link

ContributorAuthor

erlend-aasland commentedSep 26, 2020•
edited
Loading

@vstinner I've prepared the other PR's, and after applying the same suggestions to every (upcoming) PR, I've gotten rid of the reference leaks. So now, all the sqlite3 types are ready. I suggest to squash the statement and prepare protocol type in one PR, and then keep the rest as separate PRs.

vstinner merged commita937ab4 intopython:master

Sep 27, 2020

bedevere-bot removed the awaiting review label

Sep 27, 2020

Copy link

Member

vstinner commentedSep 27, 2020

Merged, thanks! You can now convert the next static types ;-)

Copy link

ContributorAuthor

erlend-aasland commentedSep 27, 2020

Merged, thanks! You can now convert the next static types ;-)

Yay, will do :) Thanks for reviewing!

erlend-aasland deleted the fix-bpo-41861/cache-and-node-types branch

September 27, 2020 18:34

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Sep 29, 2020

Merge remote-tracking branch 'origin/master' into bpo_1635741_1

e3b9365

* origin/master: (113 commits)  bpo-41773: Raise exception for non-finite weights in random.choices().  (pythonGH-22441)  bpo-41873: Add vectorcall for float() (pythonGH-22432)  bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428)  bpo-41842: Add codecs.unregister() function (pythonGH-22360)  bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433)  bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337)  bpo-41870: Use PEP 590 vectorcall to speed up bool()  (pythonGH-22427)  [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340)  bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417)  bpo-41858: Clarify line in optparse doc (pythonGH-22407)  Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424)  bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415)  bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416)  Fix logging error message (pythonGH-22410)  bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395)  bpo-41775: Make 'IDLE Shell' the shell title  (python#22399)  bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)  bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387)  bpo-41833: threading.Thread now uses the target name (pythonGH-22357)  bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633)  ...