Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-26791: update shutil.move() to provide the same symlink move behavior as the mv shell when moving a symlink into a directory that is the target of the symlink#21759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ll mv command when moving a symlink into a direcotry that is the target of a symlink
serhiy-storchaka approved these changesDec 27, 2023
Thanks@websurfer5 for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
GH-113517 is a backport of this pull request to the3.12 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 27, 2023
…vior as the mv shell when moving a symlink into a directory that is the target of the symlink (pythonGH-21759)(cherry picked from commitc66b577)Co-authored-by: Jeffrey Kintscher <49998481+websurfer5@users.noreply.github.com>
GH-113518 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestDec 27, 2023
…vior as the mv shell when moving a symlink into a directory that is the target of the symlink (pythonGH-21759)(cherry picked from commitc66b577)Co-authored-by: Jeffrey Kintscher <49998481+websurfer5@users.noreply.github.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull requestJan 22, 2024
…vior as the mv shell when moving a symlink into a directory that is the target of the symlink (pythonGH-21759)
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
…vior as the mv shell when moving a symlink into a directory that is the target of the symlink (pythonGH-21759)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull requestSep 2, 2024
…vior as the mv shell when moving a symlink into a directory that is the target of the symlink (pythonGH-21759)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
shutil.move() calls _samefile() to check whether a destination directory and a source path resolve to the same path. If they do, it assumes (per comment) that it is because of a case-insensitive filesystem and calls os.rename() to perform the move. When the source is a symlink that resolves to the destination directory, os.rename() raises an exception that is returned to the shutil.move() caller. By contrast, the mv shell command moves the symlink into the directory.
A solution to get the mv behavior is to check whether the source is a symlink when _samefile() returns True in order to bypass the os.rename() call and trigger the normal symlink handling in shutil.move().
https://bugs.python.org/issue26791