Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
bpo-41260: C impl of datetime.date.strftime() takes different keyword arg#21712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
bpo-41260: C impl of datetime.date.strftime() takes different keyword arg#21712
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… argThe parameter was named "fmt" in the Python implementation, but itwas was named "format" in the C implementation.
asottile left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
oh uh, I wasworking through this with a beginner as a mentorship opportunity -- but the patch looks correct and equivalent to what we were doing
there's another function which should be updated as well which has a similar problem
iritkatriel commentedNov 24, 2022
Should this be backported? |
asottile commentedNov 25, 2022
I don't think so -- since it ~technically changes the signatures of the functions slightly |
Uh oh!
There was an error while loading.Please reload this page.
The parameter was named "fmt" in the Python implementation, but it
was was named "format" in the C implementation.
https://bugs.python.org/issue41260