NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

bpo-41395: Close file objects in pickle and pickletools#21676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

s3bw wants to merge2 commits intopython:masterfroms3bw:bpo-41395-close-file

Closed

bpo-41395: Close file objects in pickle and pickletools#21676

s3bw wants to merge2 commits intopython:masterfroms3bw:bpo-41395-close-file

Conversation

Copy link

Contributor

s3bw commentedJul 29, 2020•
edited by bedevere-bot
Loading

File objects were not closed after reading their contents resulting in the following resource warning:

$ ./python.exe-Wall-mpicklemypickle{'a':1}sys:1:ResourceWarning:unclosedfile<_io.BufferedReadername='mypickle'>

This change ensures that the file is closed after reading the contents.

$ ./python.exe-Wall-mpicklemypickle{'a':1}

closes:https://bugs.python.org/issue41395

https://bugs.python.org/issue41395

the-knights-who-say-ni added the CLA not signed label

Jul 29, 2020

Copy link

the-knights-who-say-ni commentedJul 29, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Foxyblue

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

bedevere-bot added the awaiting review label

Jul 29, 2020

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

Jul 29, 2020

s3bw added2 commits

July 29, 2020 19:18

Close file objects after reading contents

8c3991b

    Using both pickle and pickletools from the    command line raised a resource warning    indicating that the file objects were not    closed after use.

Add news snippet

f09f836

s3bw force-pushed thebpo-41395-close-file branch fromcb64f86 tof09f836Compare

July 29, 2020 18:19

s3bw changed the title~~bpo-41395: Close file object after reading contents~~bpo-41395: Close file objects in pickle and pickletools

Jul 29, 2020

tirkarthi reviewed

Jul 30, 2020

View reviewed changes

Lib/pickle.py

		@@ -1814,4 +1814,5 @@ def _test():
		import pprint
		for f in args.pickle_file:
		obj = load(f)
		f.close()

Copy link

Member

tirkarthiJul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This will not be called ifload causes exception for cases like invalid payload. Similar case with the approach inpickletools too. Sometimes even if one file causes exception the other files in the loop will not be iterated and closed.

$ echo invalid > mypickle.pickle$ ./python -Wall -m pickle mypickle.pickleTraceback (most recent call last):  File "/root/cpython/Lib/runpy.py", line 197, in _run_module_as_main    return _run_code(code, main_globals, None,  File "/root/cpython/Lib/runpy.py", line 87, in _run_code    exec(code, run_globals)  File "/root/cpython/Lib/pickle.py", line 1816, in <module>    obj = load(f)_pickle.UnpicklingError: could not find MARKsys:1: ResourceWarning: unclosed file <_io.BufferedReader name='mypickle.pickle'>