Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-85572: Remove references to nonexisting __ne__ methods#21628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
serhiy-storchaka wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromserhiy-storchaka:docs-__ne__

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commentedJul 26, 2020
edited by bedevere-appbot
Loading

@rhettinger
Copy link
Contributor

I prefer the tables as-is. The _ne_ method does exist; it has just been moved farther along the _mro_. From a user's point of view, the method still flows automatically from the abstract methods.

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commentedJul 28, 2020
edited by bedevere-bot
Loading

There are several methods which "exist" because they are inherited from theobject class.

>>> sorted(set(object.__dict__) - set(collections.abc.Mapping.__dict__))['__class__', '__delattr__', '__dir__', '__format__', '__ge__', '__getattribute__', '__gt__', '__init__', '__init_subclass__', '__le__', '__lt__', '__ne__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__']

But there are no__lt__,__reduce__ or__format__ in the table.

I now think that it would be better to keep__ne__ in the table, but change the code (bpo-41416).

@hugovk
Copy link
Member

hugovk commentedJan 29, 2022
edited by bedevere-bot
Loading

I now think that it would be better to keep__ne__ in the table, but change the code (bpo-41416).

@serhiy-storchaka So shall we close this PR (andbpo-41400) in favour of doingbpo-41416 instead?

Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This has merge conflicts.

furkanonder reacted with thumbs up emoji
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@hugovkhugovk removed the needs backport to 3.10only security fixes labelApr 7, 2023
@erlend-aaslanderlend-aasland changed the titlebpo-41400: Remove references to nonexisting __ne__ methodsgh-85572: Remove references to nonexisting __ne__ methodsJan 5, 2024
@hugovkhugovk added needs backport to 3.12only security fixes and removed needs backport to 3.11only security fixes labelsApr 11, 2024
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.13bugs and security fixes labelMay 9, 2024
@hugovkhugovk removed the needs backport to 3.12only security fixes labelApr 10, 2025
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel requested changes

@rhettingerrhettingerrhettinger approved these changes

Assignees
No one assigned
Labels
awaiting changesdocsDocumentation in the Doc dirneeds backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixesskip news
Projects
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@serhiy-storchaka@rhettinger@hugovk@bedevere-bot@iritkatriel@ambv@the-knights-who-say-ni@ezio-melotti

[8]ページ先頭

©2009-2025 Movatter.jp