NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

bpo-41100: add runtime checks for MACOSX_DEPLOYMENT_TARGET=10.10#21576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

lawrence-danna-apple wants to merge2 commits intopython:masterfromlawrence-danna-apple:postback-runtime-checks

Closed

bpo-41100: add runtime checks for MACOSX_DEPLOYMENT_TARGET=10.10#21576

lawrence-danna-apple wants to merge2 commits intopython:masterfromlawrence-danna-apple:postback-runtime-checks

Conversation

Copy link

Contributor

lawrence-danna-apple commentedJul 21, 2020•
edited by bedevere-bot
Loading

In order to support a universal2 build, supporting Mac OS 11 on arm64 and Mac OS on
x86_64 going back to 10.10, we need to add in runtime checks for functions that will
be detected as present by autoconf, because they are in the SDK, but which did not
exist in Mac OS 10.10. This fixes all the instances of -WWunguarded-availability-new
when building with MACOSX_DEPLOYMENT_TARGET=10.10

https://bugs.python.org/issue41100

add runtime checks for MACOSX_DEPLOYMENT_TARGET=10.10

fceec42

In order to support a universal2 build, supporitng Mac OS 11 on arm64 and Mac OS onx86_64 going back to 10.10, we need to add in runtime checks for functions that willbe detected as present by autoconf, because they are in the SDK, but which did notexist  in Mac OS 10.10.    This fixes all the instances of -WWunguarded-availability-newwhen building with MACOSX_DEPLOYMENT_TARGET=10.10

lawrence-danna-apple requested review fromabalkin,pganssle andtiran ascode owners

July 21, 2020 02:28

the-knights-who-say-ni added the CLA signed label

Jul 21, 2020

bedevere-bot added the awaiting review label

Jul 21, 2020

📜🤖 Added by blurb_it.

a097234

lawrence-danna-apple mentioned this pull request

Jul 21, 2020

bpo-41100: ctypes fixes for arm64 Mac OS#21249

Closed

Copy link

ContributorAuthor

lawrence-danna-apple commentedJul 21, 2020

oops, this isn't quite right yet.

Copy link

gh-doot commentedJul 21, 2020

im just new to github.. what does that mean?

lawrence-danna-apple closed this

Jul 21, 2020

lawrence-danna-apple deleted the postback-runtime-checks branch

July 21, 2020 05:57

Copy link

ContributorAuthor

lawrence-danna-apple commentedJul 21, 2020

OK it's fixed now

maxbelanger reviewed

Jul 21, 2020

View reviewed changes

Modules/posixmodule.c

Comment on lines +89 to +90

		#defineHAVE_PREADV_RUNTIME __builtin_available(macos 10.16, ios 14, tvos 14, watchos 7, *)
		#defineHAVE_PWRITEV_RUNTIME __builtin_available(macos 10.16, ios 14, tvos 14, watchos 7, *)

Copy link

Contributor

maxbelangerJul 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Curious, what is the proper way to detect Big Sur,10.16 or11?

Copy link

sumanthratnaJul 21, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

~~My understanding is that on current macs (with the Intel processor), upgrading to Big Sur will result in 10.16. However, on Apple Silicon, Big Sur will be 11.0.~~

Copy link

ContributorAuthor

lawrence-danna-appleJul 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's 11.0 for both Intel and Arm, however before the public disclosure it was marked as 10.16, so 10.16 appears in some of the headers likeuio.h, and will be recognized by_builtin_available. I just copied 10.16 out ofuio.h, but it's confusing so I'll change it to 11.0.