Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-85525: Indicate supported sound header formats#21575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nanjekyejoannah merged 4 commits intopython:mainfromnanjekyejoannah:sndhdr
Oct 15, 2022

Conversation

nanjekyejoannah
Copy link
Contributor

@nanjekyejoannahnanjekyejoannah commentedJul 21, 2020•
edited by bedevere-bot
Loading

@hugovk
Copy link
Member

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

SeePEP 594 – Removing dead batteries from the standard library and#91217.

@AlexWaygood
Copy link
Member

Note the sndhdr module is deprecated in 3.11 and set for removal in 3.13.

SeePEP 594 – Removing dead batteries from the standard library and#91217.

Nonetheless, this does look like a relatively simple docs enhancement that would be quite nice to have. It would be nice if it could get over the line.

@JelleZijlstraJelleZijlstra self-requested a reviewApril 12, 2022 13:49
@JelleZijlstraJelleZijlstra changed the titlebpo-41353: Indicate supported sound header formatsgh-85525: Indicate supported sound header formatsApr 12, 2022
@JelleZijlstraJelleZijlstra removed their request for reviewApril 13, 2022 02:56
@nanjekyejoannah
Copy link
ContributorAuthor

nanjekyejoannah commentedApr 13, 2022•
edited
Loading

@willingc can you help review this and see if it can be merged?

@AA-TurnerAA-Turner added needs backport to 3.10only security fixes needs backport to 3.11only security fixes docsDocumentation in the Doc dir and removed CLA signed labelsJun 7, 2022
@AA-Turner
Copy link
Member

I agree with@AlexWaygood that this would be useful to consumers of the module for 3.10 through 3.12 -- I've no comments beyond Hugo's points though.

A

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelJul 30, 2022
@miss-islington
Copy link
Contributor

Thanks@nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@nanjekyejoannah, I had trouble checking out the3.11 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.11

@miss-islington
Copy link
Contributor

Sorry,@nanjekyejoannah, I could not cleanly backport this to3.10 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.10

@AlexWaygoodAlexWaygood removed the needs backport to 3.11only security fixes labelOct 15, 2022
@AlexWaygoodAlexWaygood added the needs backport to 3.11only security fixes labelOct 15, 2022
@miss-islington
Copy link
Contributor

Thanks@nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@nanjekyejoannah, I had trouble checking out the3.11 backport branch.
Please backport usingcherry_picker on command line.
cherry_picker 05c042e70786bd2e3fcb274d185e1e0a54dab5a7 3.11

@AlexWaygoodAlexWaygood added needs backport to 3.11only security fixes and removed needs backport to 3.11only security fixes labelsOct 15, 2022
@miss-islington
Copy link
Contributor

Thanks@nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 15, 2022
* Indicate supported sound header formats* modify file namesCo-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>(cherry picked from commit05c042e)Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
@bedevere-bot
Copy link

GH-98277 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelOct 15, 2022
miss-islington added a commit that referenced this pull requestOct 15, 2022
* Indicate supported sound header formats* modify file namesCo-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>(cherry picked from commit05c042e)Co-authored-by: Joannah Nanjekye <33177550+nanjekyejoannah@users.noreply.github.com>
@ZeroIntensityZeroIntensity removed the needs backport to 3.10only security fixes labelFeb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@merwokmerwokmerwok left review comments

@hugovkhugovkhugovk left review comments

Assignees

@nanjekyejoannahnanjekyejoannah

Labels
docsDocumentation in the Doc dirskip newsstaleStale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

10 participants
@nanjekyejoannah@hugovk@AlexWaygood@AA-Turner@miss-islington@bedevere-bot@merwok@the-knights-who-say-ni@ZeroIntensity@JelleZijlstra
[8]ページ先頭
©2009-2025 Movatter.jp