NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

bpo-1635741: Release Unicode interned strings at exit#21269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:masterfromvstinner:clear_interned

Jul 1, 2020

Merged

bpo-1635741: Release Unicode interned strings at exit#21269

vstinner merged 1 commit intopython:masterfromvstinner:clear_interned

Jul 1, 2020

Conversation

Copy link

Member

vstinner commentedJul 1, 2020•
edited by bedevere-bot
Loading

PyUnicode_InternInPlace() now ensures that interned strings are
ready.
Add _PyUnicode_ClearInterned().
Py_Finalize() now releases Unicode interned strings:
call _PyUnicode_ClearInterned().

https://bugs.python.org/issue1635741

bpo-1635741: Release Unicode interned strings at exit

316e001

* PyUnicode_InternInPlace() now ensures that interned strings are  ready.* Add _PyUnicode_ClearInterned().* Py_Finalize() now releases Unicode interned strings:  call _PyUnicode_ClearInterned().

vstinner added the skip news label

Jul 1, 2020

the-knights-who-say-ni added the CLA signed label

Jul 1, 2020

bedevere-bot added the awaiting core review label

Jul 1, 2020

Copy link

MemberAuthor

vstinner commentedJul 1, 2020

Python has between 1446 (./python -sSI -c pass command) and 4660 (run 19 tests using./python -m test and interrupt it after around 19 tests) interned strings at exit.

This PR has no significant impact on timing of the./python -sSI -c pass command:

# benchmark$ python3 -m pyperf command -o ref.json -- ./python -sSI -c pass# switch to the PR branch, make$ python3 -m pyperf command -o clear.json -- ./python -sSI -c pass$ python3 -m pyperf show ref.json Mean +- std dev: 7.56 ms +- 0.24 ms$ python3 -m pyperf compare_to ref.json clear.jsonBenchmark hidden because not significant (1): command

@shihai1991 proposed PR#21087 to solve the same problem. My PR clears interned strings before calling _PyDict_Fini() and _PyList_Fini(), since _PyUnicode_ClearInterned() uses a dict and a list.

vstinner mentioned this pull request

Jul 1, 2020

bpo-1635741: Enable unicode_release_interned() without insure or valgrind.#21087

Closed

vstinner merged commit666ecfb intopython:master

Jul 1, 2020

bedevere-bot removed the awaiting core review label

Jul 1, 2020

vstinner deleted the clear_interned branch

July 1, 2020 23:20

arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request

Jul 21, 2020

bpo-1635741: Release Unicode interned strings at exit (pythonGH-21269)

e0cb931

* PyUnicode_InternInPlace() now ensures that interned strings are  ready.* Add _PyUnicode_ClearInterned().* Py_Finalize() now releases Unicode interned strings:  call _PyUnicode_ClearInterned().