Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
bpo-41100: ctypes: check _dyld_shared_cache_contains_path in find_library#21241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
bpo-41100: ctypes: check _dyld_shared_cache_contains_path in find_library#21241
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ronaldoussoren commentedJun 30, 2020
Is it necessary to add In PyObjC similar code to find_library assumes that a library is in the shared cache if (a) the library path starts with "/usr/lib" or "/lib" and (b) there is a symbolic link (such as /usr/lib/libSystem.dylib). I'm not too happy about using a private symbol, that tends to be fragile. |
lawrence-danna-apple commentedJun 30, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
"I'm not too happy about using a private symbol, that tends to be fragile" I just spoke to dyld engineers, _dyld_shared_cache_contains_path will be made a public API in Mac OS 11 Seed 3 I was thinking we'd add it as a private symbol now, and then update it to including |
lawrence-danna-apple commentedJun 30, 2020
"Is it necessary to add _dyld_shared_cache_contains_path, or is safe to assume libraries in /usr/lib and /lib are in the cache?" I think it is necessary, because if we just assumed any name under /lib was in the cache, then it would think literally anything you ask for is in the cache. find_library("FOO") would return /lib/libFOO.dylib, which is not what we want. |
System libraries in Mac OS 11 may be present only in the shared cache,with the actual mach-o file not present in the corresponding locationon the filesystem. ctypes.util.find_library should check theshared cache in order to behave consistently across Mac OS 10.15and earlier and Mac OS 11.0 and later.
4890613 to311f8c3CompareModules/_ctypes/callproc.c Outdated
| #endif | ||
| #ifdef__APPLE__ | ||
| externbool_dyld_shared_cache_contains_path(constchar*path) __attribute__((weak_import)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This can be replaced with#include <mach-o/dyld.h> after Seed 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we please wait for official API here? or at least have another PR to clean this up which we can merge later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seed 3 is out today 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks like it got pushed out to seed 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is in Xcode 12 beta 4, only enough with the same name but with documentation in a header file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
yup, updated the pull request to includemach-o/dyld.h instead of declaring a weak import
... and wait for Python fix inpython/cpython#21241
ned-deily commentedOct 26, 2020
Thanks for the PR. It has been included in and superseded byGH-22855, |
Uh oh!
There was an error while loading.Please reload this page.
System libraries in Mac OS 11 may be present only in the shared cache,
with the actual mach-o file not present in the corresponding location
on the filesystem. ctypes.util.find_library should check the
shared cache in order to behave consistently across Mac OS 10.15
and earlier and Mac OS 11.0 and later.
https://bugs.python.org/issue41100