NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

bpo-41100: use system libffi for Mac OS 10.15 and up#21239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

lawrence-danna-apple wants to merge2 commits intopython:masterfromlawrence-danna-apple:postback-0003

Closed

bpo-41100: use system libffi for Mac OS 10.15 and up#21239

lawrence-danna-apple wants to merge2 commits intopython:masterfromlawrence-danna-apple:postback-0003

Conversation

Copy link

Contributor

lawrence-danna-apple commentedJun 30, 2020•
edited by bedevere-bot
Loading

The vendored libffi sources do not support arm64 Mac OS. Recent versions of mac OS include libffi, including Mac OS 11 on arm64.

This updates setup.py to default to the system libffi on Mac OS 10.15 and forward. It also updates
detect_ctypes to prefer finding libffi in the Xcode SDK, rather than /usr/include

Also, when the Mac OS libffi is used, it removes malloc_closure.c from the sourcs for _ctypes.
libffi already comes with ffi_closure_alloc, and it is not compatible with the one in
malloc_closure.c

https://bugs.python.org/issue41100

use system libffi for Mac OS 10.15 and up

6c2d55b

This updates setup.py to default to the system libffi on Mac OS 10.15 and forward.   It also updatesdetect_ctypes to prefer finding libffi in the Xcode SDK, rather than /usr/includeAlso, when the Mac OS libffi is used, it removes malloc_closure.c from the sourcs for _ctypes.libffi already comes with ffi_closure_alloc, and it is not compatible with the one inmalloc_closure.c