Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[3.7] bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interfac…#21231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry we only accept security patch for 3.5-3.7.
I close this PR cc@ericvsmith
On the bpo issue, I've asked the release manager to weigh in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since this issue is reported as theCVE-2020-14422.
I am okay to merge this PR as the security issue.
But waiting for@ned-deily and@ericvsmith 's comment :)
As I commented on the bpo issue, please add the CVE to the NEWS item. |
…terface (pythonGH-21033)The __hash__() methods of classes IPv4Interface and IPv6Interface had issueof generating constant hash values of 32 and 128 respectively causing hash collisions.The fix uses the hash() function to generate hash values for the objectsinstead of XOR operation(cherry picked from commitb30ee26)Co-authored-by: Ravi Teja P <rvteja92@gmail.com>Signed-off-by: Tapas Kundu <tkundu@vmware.com>
Uh oh!
There was an error while loading.Please reload this page.
…e (GH-21033)
Thehash() methods of classes IPv4Interface and IPv6Interface had issue
of generating constant hash values of 32 and 128 respectively causing hash collisions.
The fix uses the hash() function to generate hash values for the objects
instead of XOR operation
(cherry picked from commitb30ee26)
Co-authored-by: Ravi Teja Prvteja92@gmail.com
Signed-off-by: Tapas Kundutkundu@vmware.com
https://bugs.python.org/issue41004