NotificationsYou must be signed in to change notification settings
Fork32k
Star67.2k

[3.8] bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033)#21221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

miss-islington merged 1 commit intopython:3.8frommiss-islington:backport-b30ee26-3.8

Jun 29, 2020

Merged

[3.8] bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033)#21221

miss-islington merged 1 commit intopython:3.8frommiss-islington:backport-b30ee26-3.8

Jun 29, 2020

Conversation

Copy link

Contributor

miss-islington commentedJun 29, 2020•
edited
Loading

Thehash() methods of classes IPv4Interface and IPv6Interface had issue
of generating constant hash values of 32 and 128 respectively causing hash collisions.
The fix uses the hash() function to generate hash values for the objects
instead of XOR operation
(cherry picked from commitb30ee26)

Co-authored-by: Ravi Teja Prvteja92@gmail.com

https://bugs.python.org/issue41004

Automerge-Triggered-By:@ericvsmith

bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (

bd32b1f

pythonGH-21033)The __hash__() methods of classes IPv4Interface and IPv6Interface had issueof generating constant hash values of 32 and 128 respectively causing hash collisions.The fix uses the hash() function to generate hash values for the objectsinstead of XOR operation(cherry picked from commitb30ee26)Co-authored-by: Ravi Teja P <rvteja92@gmail.com>