Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-40968: Send http/1.1 ALPN extension#20959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tiran merged 1 commit intopython:masterfromtiran:bpo-40968-alpn
Nov 13, 2020

Conversation

@tiran
Copy link
Member

@tirantiran commentedJun 18, 2020•
edited by bedevere-bot
Loading

@tiran
Copy link
MemberAuthor

  • It's a low-risk change. cURL has been setting the ALPN indicator for years.
  • The change fixes a problem with servers that require an ALPN extension to indicate HTTP version.
  • Need to figure out how to test the change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are this comment and the functionality out of sync here sincehttp_vsn_str can beHTTP/1.0, etc?http/1.1,http/1.0, andhttp/0.9 are all valid ALPN protocol IDs but the comment and changelogs only mention 1.1. This might be fine anyways but something I noticed.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm now checking_http_vsn and only send the ALPN extension when the version is11 (HTTP/1.1).

Signed-off-by: Christian Heimes <christian@python.org>
@tirantiran added type-featureA feature request or enhancement and removed needs backport to 3.7 type-bugAn unexpected behavior, bug, or error labelsNov 13, 2020
@tirantiran marked this pull request as ready for reviewNovember 13, 2020 09:05
Copy link
Contributor

@sethmlarsonsethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@tirantiran merged commitf97406b intopython:masterNov 13, 2020
@bedevere-bot
Copy link

@tiran: Please replace# withGH- in the commit message next time. Thanks!

@tirantiran deleted the bpo-40968-alpn branchNovember 13, 2020 15:37
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 13, 2021
Signed-off-by: Christian Heimes <christian@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sethmlarsonsethmlarsonsethmlarson approved these changes

Assignees

No one assigned

Labels

type-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran@bedevere-bot@sethmlarson@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp